Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751244AbWEFDjq (ORCPT ); Fri, 5 May 2006 23:39:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751815AbWEFDjq (ORCPT ); Fri, 5 May 2006 23:39:46 -0400 Received: from nz-out-0102.google.com ([64.233.162.194]:4622 "EHLO nz-out-0102.google.com") by vger.kernel.org with ESMTP id S1751244AbWEFDjp convert rfc822-to-8bit (ORCPT ); Fri, 5 May 2006 23:39:45 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=HVPWmBsPjybxX76KmQHQSl9sr3mi1vrXByqtbDKa1q3m0mls6hBbiDg/f3a4vzAQ2aM99QywrmWQIU5mJa8+r3fDbSjkCFkdBnJ9SC/nHD3Ts6gM0w1J87CA8nRjb/F/oLX4BxzTxyOKU7YRMHcjRwm8JifQbg432G5Nl6qXqsI= Message-ID: <9e4733910605052039n7d2debbse0fd07e0d1d059fb@mail.gmail.com> Date: Fri, 5 May 2006 23:39:44 -0400 From: "Jon Smirl" To: "Dave Airlie" Subject: Re: Add a "enable" sysfs attribute to the pci devices to allow userspace (Xorg) to enable devices without doing foul direct access Cc: "Greg KH" , "Ian Romanick" , "Dave Airlie" , "Arjan van de Ven" , linux-kernel@vger.kernel.org In-Reply-To: <21d7e9970605051857l4415a04ai7d1b1f886bb01cee@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <445BA584.40309@us.ibm.com> <9e4733910605051314jb681476y4b2863918dfae1f8@mail.gmail.com> <20060505202603.GB6413@kroah.com> <9e4733910605051335h7a98670ie8102666bbc4d7cd@mail.gmail.com> <20060505210614.GB7365@kroah.com> <9e4733910605051415o48fddbafpf0f8b096f971e482@mail.gmail.com> <20060505222738.GA8985@kroah.com> <9e4733910605051705j755ad61dm1c07c66c2c24c525@mail.gmail.com> <21d7e9970605051857l4415a04ai7d1b1f886bb01cee@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 29 On 5/5/06, Dave Airlie wrote: > > It has everything to do with the 'enable' file. The 'enable' file lets > > you change the state of the hardware without an ownership mechanism. > > Other device users will not be notified of the state change. Since the > > other users can't be sure of the state of the hardware when they are > > activated, they will have to reload their state into the hardware on > > every activation. > > Jon > > you seem to miss the fact that this can be done now without the enable > flag, setpci can be used to disable the BARs, again the enable flag > doesn't change that.... Existence of a problem API doesn't justify creating more of them. The minimal vga driver combined with new_id scheme is very simple, it works on older kernels, it does not create a new API and it tracks ownership of the hardware state. But instead everyone seems to want the 'enable' file despite it's obvious problems. -- Jon Smirl jonsmirl@gmail.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/