Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1785857ybh; Fri, 17 Jul 2020 00:39:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRz43Ot0Tf+gwL529tIgi8P+veCrChxQeHoLlHynR2mTDR6wvHDgfIgO/zUwCHMPujxWZt X-Received: by 2002:a05:6402:17ee:: with SMTP id t14mr8208054edy.359.1594971573096; Fri, 17 Jul 2020 00:39:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594971573; cv=none; d=google.com; s=arc-20160816; b=ttnieVIY2DhC3Hk1xY+nRQDA8TzUK+WfT5/Xa1K4frocNVZgtWzOZsGwoGMSgppriq pCZXHhsOxQB9SaS8zV0Eyf+LnQ2m7PFPoK6Tn2FCheR4hGrBFfARFq2bM9xBGeJ8i3Hf xng/mxRNTlEaQMR7GrxGv4uG5g4VAmcE6zkhSoefqjmAIXsC0kwDlCeoa/9k3tLmLkLA yYcMXyPF04qkzmCXoonN40QE7gedq8zU7iN5E5fCDrlYJgUElE9UBE5RLO8Aop2YodOW gB+F24oQOQVsnPf0sH2rAvaDBZvEL7pZz8dDWPmmlipxkTFLFyRONnx59szyzMB2v6hv kIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=PbYU91Pc8bIm7iU5Q0D2lIRzsk6tixhX89krj51KD5ELOy4CnaR5qAGLFmViXvZ39Z 5QTm76f4aymKF1CtupNxL3raeRdEKrNhMCaissUgb7v0Lt9fYkRRBKJx7p74M7JyGvEV +qbtjGGgUu7XnCLJOZQk7H/y0dEEDA5FB4klAKDjHvNO+Su2j/Ml3MdfxDbhaeT6VWCe 5r7Ak8ePVXnqPPnoiMobcl5TgNZs23ctVAQxg2lKwmL6ylUIxydFYXqdLC7fBmoDs3t7 F1d2+dfKawx8yuNNwtIlBjksHAcVHE0QQlZwAdYWW4CVAcTIW5Y/qAUxIwASPzo6y2Yw +n1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BBGOosQ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh22si4709582ejb.553.2020.07.17.00.39.10; Fri, 17 Jul 2020 00:39:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BBGOosQ4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728124AbgGQHgV (ORCPT + 99 others); Fri, 17 Jul 2020 03:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgGQHgU (ORCPT ); Fri, 17 Jul 2020 03:36:20 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E069C061755; Fri, 17 Jul 2020 00:36:20 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id 207so5005587pfu.3; Fri, 17 Jul 2020 00:36:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=BBGOosQ4rdLrE+BvisBUEjDWy3yz8138qDCHb1T8Ez7G4qhwkV+RHgJNp58TK0pNzw fbIT0slrgz6NFbzyz1xXWjcIeN6JT2QyH/ZoqdMJ1nsGh+dVkeCYDaO2FY3u7CYla5du 6bQIIocz5RXLEUlF0Y2gajFtsKLscXOjXs8zypqlSe3S7DxWtInE7ywqvJas2Y75hTXB SCJZ6jKEo9gmZL+zWTVmbC+PYNLIJ2bJfrvtjW5WWIGsGfiixA+zfB/X13qSY+ltR+mR MI6VHRRvNzZgWyrns4aMJw8Rv9vXbAcaBkUoknzjMKdbEXBZpeDpdSkPq8TnxBYh9kYu /ddA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uoIcD6K+jqu+zRT0DyWA5LlYkttEC1REY3iS6fetokg=; b=SSHAV28cnIreHkw1+DvpEVNQsYWfABYTx/Kxf/hJXAmiUvKUQAJY4HbrVii7383927 j+aWSzHoZIfdhAc75N+kh95imAW6Gik3xEFckmH6wZ69U2wX0pHNRx7NVzReCUH88pOa F7/V81KTEJDZndob2SPTEgip3Udhs8MNABAQS3ZssOTZAXqIOfZXDrTgVmiydqQ6H3j6 dGIyHJJJXwDunrmiTFq7IYMbnjirdyKDVtD/AfFIKc2piu7yCiui3tMXYvLBgLPmMqfe OXbGb8c9/dyWVwUpyUuTesQOvgqh6CBXfnIAnQJBtINwZJFBIhU4YtDqaqvp9HSWL9J2 bOZA== X-Gm-Message-State: AOAM532mFPsQOOPQhRVV1B7qEgvMjPTxg65I3kGp3gPlZjUOS0RV6vgu fHm19Tgyt5OusioV+mjhyOo= X-Received: by 2002:a63:745:: with SMTP id 66mr7868463pgh.316.1594971380040; Fri, 17 Jul 2020 00:36:20 -0700 (PDT) Received: from varodek.iballbatonwifi.com ([103.105.153.67]) by smtp.gmail.com with ESMTPSA id z25sm6794704pfg.140.2020.07.17.00.36.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 00:36:19 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Mauro Carvalho Chehab Cc: Vaibhav Gupta , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, Shuah Khan Subject: [PATCH v3 3/6] cx25821: use generic power management Date: Fri, 17 Jul 2020 13:04:33 +0530 Message-Id: <20200717073436.249623-4-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200717073436.249623-1-vaibhavgupta40@gmail.com> References: <20200717073436.249623-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .suspend() and .resume() callbacks are not defined for this driver. Still, their power management structure follows the legacy framework. To bring it under the generic framework, simply remove the binding of callbacks from struct "pci_driver". Compile-tested only. Signed-off-by: Vaibhav Gupta --- drivers/media/pci/cx25821/cx25821-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/media/pci/cx25821/cx25821-core.c index 41be22ce66f3..55018d9e439f 100644 --- a/drivers/media/pci/cx25821/cx25821-core.c +++ b/drivers/media/pci/cx25821/cx25821-core.c @@ -1374,9 +1374,6 @@ static struct pci_driver cx25821_pci_driver = { .id_table = cx25821_pci_tbl, .probe = cx25821_initdev, .remove = cx25821_finidev, - /* TODO */ - .suspend = NULL, - .resume = NULL, }; static int __init cx25821_init(void) -- 2.27.0