Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Jul 2020 10:24:12 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     Ian Rogers <irogers@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        LKML <Linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>, kan.liang@intel.com,
        "Jin, Yao" <yao.jin@intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH] perf evsel: Don't set sample_regs_intr/sample_regs_user
 for dummy event
Message-ID: <20200717082412.GA522549@krava>
References: <20200703004215.24418-1-yao.jin@linux.intel.com>
 <20200703110042.GA3282312@krava>
 <9fa0bd83-b21e-7bc2-af81-799f8e99f73b@linux.intel.com>
 <CAP-5=fUjUc7yAA2wyes+DhMkwP9Mw0Lu5gy=XOnugy=vW1jwoQ@mail.gmail.com>
 <b527838b-42e8-b48a-debc-fd91923150d5@linux.intel.com>
 <deb02b38-49eb-088d-6ebf-b5396e50c725@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <deb02b38-49eb-088d-6ebf-b5396e50c725@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 17, 2020 at 11:33:46AM +0800, Jin, Yao wrote:
> Hi,
> 
> On 7/6/2020 8:55 AM, Jin, Yao wrote:
> > Hi Ian,
> > 
> > On 7/6/2020 8:47 AM, Ian Rogers wrote:
> > > On Fri, Jul 3, 2020 at 5:31 PM Jin, Yao <yao.jin@linux.intel.com> wrote:
> > > > 
> > > > Hi Jiri,
> > > > 
> > > > On 7/3/2020 7:00 PM, Jiri Olsa wrote:
> > > > > On Fri, Jul 03, 2020 at 08:42:15AM +0800, Jin Yao wrote:
> > > > > > Since commit 0a892c1c9472 ("perf record: Add dummy event during system wide synthesis"),
> > > > > > a dummy event is added to capture mmaps.
> > > > > > 
> > > > > > But if we run perf-record as,
> > > > > > 
> > > > > > ?? # perf record -e cycles:p -IXMM0 -a -- sleep 1
> > > > > > ?? Error:
> > > > > > ?? dummy:HG: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'
> > > > > > 
> > > 
> > > Sorry for the breakage caused by modifying the dummy event. Could we
> > > add a test to cover the issue? Perhaps in tools/perf/tests/shell/.
> > > Trying to reproduce with a register on my skylakex on a 5.6.14 kernel
> > > with:
> > > 
> > > $ perf record -e cycles:p -IAX -a -- sleep 1
> > > 
> > > succeeds.
> > > 
> > > Thanks,
> > > Ian
> > > 
> > 
> > -IAX should be no problem. The issue only occurs on the platform with
> > extended regs supports, such as ICL. So I don't know if it's suitable to
> > add it to perf test suite.
> > 
> > Thanks
> > Jin Yao
> > 
> 
> Can this fix patch be accepted?

hi,
my only concern was that it would conflict with Adrian's patch,
other than that:

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka