Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] [SCSI] libsas: add missing newline when printing 'enable'
 by sysfs
To:     John Garry <john.garry@huawei.com>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <guohanjun@huawei.com>
References: <1594971374-40210-1-git-send-email-wangxiongfeng2@huawei.com>
 <648c18d0-cc0a-f444-e774-e0938f697e90@huawei.com>
From:   Xiongfeng Wang <wangxiongfeng2@huawei.com>
Message-ID: <6381e401-53d3-3693-03ea-f709e95a3ec8@huawei.com>
Date:   Fri, 17 Jul 2020 16:28:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <648c18d0-cc0a-f444-e774-e0938f697e90@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,

On 2020/7/17 15:54, John Garry wrote:
> On 17/07/2020 08:36, Xiongfeng Wang wrote:
> 
> Hi,
> 
> I think "scsi: scsi_transport_sas: " would be a better subject prefix, as this
> is not libsas code.
> 
>> When I cat sysfs file 'enable' below 'sas_phy', it displays as follows.
>> It's better to add a newline for easy reading.
>>
>> [root@localhost ~]# cat
>> /sys/devices/pci0000:00/0000:00:0d.0/0000:0f:00.0/host3/phy-3:2/sas_phy/phy-3:2/enable
>>
>> 1[root@localhost ~]#
>>
>> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> 
> Apart from above,
> Reviewed-by: John Garry <john.garry@huawei.com>

Thanks for your review. I will send another version.

Thanks,
Xiongfeng

> 
>> ---
>>   drivers/scsi/scsi_transport_sas.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/scsi_transport_sas.c
>> b/drivers/scsi/scsi_transport_sas.c
>> index 182fd25..e443dee 100644
>> --- a/drivers/scsi/scsi_transport_sas.c
>> +++ b/drivers/scsi/scsi_transport_sas.c
>> @@ -563,7 +563,7 @@ static ssize_t do_sas_phy_enable(struct device *dev,
>>   {
>>       struct sas_phy *phy = transport_class_to_phy(dev);
>>   -    return snprintf(buf, 20, "%d", phy->enabled);
>> +    return snprintf(buf, 20, "%d\n", phy->enabled);
>>   }
>>     static DEVICE_ATTR(enable, S_IRUGO | S_IWUSR, show_sas_phy_enable,
>>
> 
> 
> .