Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1831749ybh; Fri, 17 Jul 2020 02:19:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztPma/B/yKI+9dtlPgdyVRgzbv/PskajzWPbpk/S5uGmp9cOMMScaPy7KXG01q2USsJTNG X-Received: by 2002:a50:bb2f:: with SMTP id y44mr8277808ede.351.1594977540032; Fri, 17 Jul 2020 02:19:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594977540; cv=none; d=google.com; s=arc-20160816; b=DUMY9kHiKLCDhf2Y+oN+y3LBIgPBs9SEZKpHFqnnvt9YGjVhnVqR7rUPWFvQPyGMBQ JP0umz7B+F8WAcxiFgjuV7doe56PPZJwvTkqRwsTflGEqOO/BXGFbfeRaKNvnhIe9CnS /DflEXDczQTVxfPXVlkbyVFtQzNzkU8mQR7nWvzlBNWxHzQAIK7mrsVU9uA+52Sj7eKC jkVKwHGqCbwahEGDFmL997AR5Om/Ifq9nMp5Bpy018C/W7AYD+Nr3YYwqy7aF4mbuC61 iPFXTdsq1uWZb1bFMQ9leZJS2geBFPbn3pU7syL5p0Aq5AkmQa8p47n1W23u7XoyATGE srfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ABtoKcunWta1zPd9OAU4HivGakSrvH6t7PoGrVg1IHw=; b=yJBYC9+TU6dvDHjGjNv0/7G+PwbGPhWNNGeQBGneYueupGdBOyz81Vrp7l8MT+j9Pg on1ovVzwDlaoql3HWSKvdXq0oZe1KUefbmjtrBm9+niYLtNTy/KphXjXHXzRGWgs5Rsn jDoSHFrHN9UuFlbRD42671CDs29bCRnjzIXr7B+CTyZaOa4dpE01Trst8r+a0FZumMfs k7GCxHF4DClsCHRfwYBLyUNjRoy8xr88Ri4oFWtiJB8EopBDD6pnQ2BV20K4zYRYJm9P F43BmQim2vOJVF7tCTdqxirNJAPBCEa+PCumMqGxTCRmE5DOFHE9nJtM4ZL0D14oIAyE uW6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b="xR7/TE9+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y8si5298197edw.59.2020.07.17.02.18.37; Fri, 17 Jul 2020 02:19:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@tessares-net.20150623.gappssmtp.com header.s=20150623 header.b="xR7/TE9+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbgGQJSM (ORCPT + 99 others); Fri, 17 Jul 2020 05:18:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725864AbgGQJSL (ORCPT ); Fri, 17 Jul 2020 05:18:11 -0400 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5683DC061755 for ; Fri, 17 Jul 2020 02:18:11 -0700 (PDT) Received: by mail-ej1-x642.google.com with SMTP id o18so10003666eje.7 for ; Fri, 17 Jul 2020 02:18:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tessares-net.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ABtoKcunWta1zPd9OAU4HivGakSrvH6t7PoGrVg1IHw=; b=xR7/TE9+zWjcsvx6d03jd1AgLl1RxCF+57iDGUw8QqO8NNJiU5y/1PDhMHyK6SBPD0 Tu9kE2ltrVcgIGDsEFYeGOdvGGs9gXhWrY0fvfmRtJuRWzhuLiSsJxij8VwijPfHjTPS 3aRzO2LOdNynO+M1Cxqg8LEaNT7+cWaMS9ZleuZy42uIKF7zbE+VVsfyNZHqDLg2WCO5 2IhHaXOEiidwv/4zssU9rGm6ibTKTyOzBFUfh4ZlLc65xFj4ZNu5VWofuJadgyUIYj5C Y93p7sEtG5rh/7aWXf9IEREZyDETtvRRffJXB7kNBwNCJiHJc9kale3U3Oqjmxgbkhyq rtqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ABtoKcunWta1zPd9OAU4HivGakSrvH6t7PoGrVg1IHw=; b=JCiWj+2aPqwpdji8NxzdMqg++kboWkXJ6VfsGLYvn2Cl+7NslwjX71LqMcc4dWrbJz KjhYmznA81B/myldkfma3lR7WI2NRXttFo8GR+I+CksxOcf0On3a+tsBWcd+GZZw1Hq1 JLtk1woghAW+5aqknFG7Yp3guRKz8xFf9K9X4yd9Kke9oTf7r/gy0mGRVam0V3Sb//YE MTTUSF2+enzNRnTH2+7sMQ7fAwDV0YohBLICpRNnm3AYOqXp7sQSKciKEs+LDkoDNZoy iudeOHvEE9N7O3UX6MqJICYT97XAZTaPPsiNF6PXD3a3pxSVX01//VNzOSeXf32To+CG vPHg== X-Gm-Message-State: AOAM5320Gw13nn/OsaNk0WFVLWL/U0tlNd0zVngKQZSH+m3wvmMA+gwN whmxFtNTvNwk+dTuWdAkDG4ywA== X-Received: by 2002:a17:907:426c:: with SMTP id nx20mr7604495ejb.548.1594977490002; Fri, 17 Jul 2020 02:18:10 -0700 (PDT) Received: from tsr-lap-08.nix.tessares.net ([81.246.10.41]) by smtp.gmail.com with ESMTPSA id p4sm7541372eji.123.2020.07.17.02.18.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2020 02:18:08 -0700 (PDT) Subject: Re: [MPTCP] [PATCH 05/22] net: remove compat_sock_common_{get,set}sockopt To: Christoph Hellwig , "David S. Miller" Cc: Alexei Starovoitov , Daniel Borkmann , Chas Williams <3chas3@gmail.com>, Pablo Neira Ayuso , Jozsef Kadlecsik , Alexey Kuznetsov , Hideaki YOSHIFUJI , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-sctp@vger.kernel.org, linux-arch@vger.kernel.org, linux-bluetooth@vger.kernel.org, bridge@lists.linux-foundation.org, linux-can@vger.kernel.org, dccp@vger.kernel.org, linux-wpan@vger.kernel.org, mptcp@lists.01.org References: <20200717062331.691152-1-hch@lst.de> <20200717062331.691152-6-hch@lst.de> From: Matthieu Baerts Message-ID: <203f5f41-1de0-575e-864b-53a9412d97f6@tessares.net> Date: Fri, 17 Jul 2020 11:18:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200717062331.691152-6-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On 17/07/2020 08:23, Christoph Hellwig wrote: > Add the compat handling to sock_common_{get,set}sockopt instead, > keyed of in_compat_syscall(). This allow to remove the now unused > ->compat_{get,set}sockopt methods from struct proto_ops. > > Signed-off-by: Christoph Hellwig > --- > include/linux/net.h | 6 ------ > include/net/sock.h | 4 ---- > net/core/sock.c | 30 ++++++------------------------ > net/mptcp/protocol.c | 6 ------ Thank you for looking at that! For MPTCP-related code: Acked-by: Matthieu Baerts Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net