Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1836290ybh; Fri, 17 Jul 2020 02:28:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4qtLV4ukU9yQBcH6BfeyNpAhceFJpKSHzx2VzSyYzPINDTKmzCgtNpETAvtfxr5cH6Xw8 X-Received: by 2002:a17:907:395:: with SMTP id ss21mr7573606ejb.181.1594978111739; Fri, 17 Jul 2020 02:28:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594978111; cv=none; d=google.com; s=arc-20160816; b=wpYvGCEdDsADXoLYIAIAphcNGxtUxWAwy1HdSEzGkPXWFywVS2qa95vUOpRhII7xAs uOwHqE48px93m7DLe/VEYlJ2g481QP3KhGufb/95zUMk6z71YBGCDuqhJnSUnc7093SV kHG8ieXd2x+FzkKL+48PpjSnfhI55HsfYo+ADzgOx3HRES2AHN++BO9FGqQKvTT9tPJr 6jAQfp1cmEZndAi+0XLHsZ2AH4iGoE7hcug6JW2l7kcfz3QPZn51VXziTvtFms0hkZGe /WeXMTJfFULV5fSqZ4QEEiepOQu9ITGy0iiz2Fyy3EqG0tQm17HLZUGs9MK+FAVjtVW5 WMow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:dkim-signature; bh=IDRMoK9XAqR3KP28NyAj73nC8S++fY+3q8RW1Xp505E=; b=aWcTnpw4+5zpOrgp7Z2LQJL4TNYHiezUu6/VUp+5nGEJhbw84SNYn41zueAwoMce9L pVZzDaidDYavwZXuiTzs+v17rsXGuU4ojvdE5n4DUn0wuymAOAKufeLDqzcRSSkFlk/d 0dhPmP8vtA1ioh5+mmkL2+YbfZpxyJuCD0OAJfHC6S61VN5FvFhEl++YESAOhCsj7clU xwWiRDraVS9661xRtuaf6uLhG+HHnnRz7oBsqHZMR5VdzVi5J6LSayxbyuIlPMXXo/Cg b0yfKttvKwCdQ1i0md5+J4J2twihtk01NHQkmAoGVsO6XjMToWoThsQEr6nXoqbXu+G4 6phQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=aUuIOdSl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bf2si4931748edb.288.2020.07.17.02.28.08; Fri, 17 Jul 2020 02:28:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=aUuIOdSl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726401AbgGQJ2D (ORCPT + 99 others); Fri, 17 Jul 2020 05:28:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726442AbgGQJ2C (ORCPT ); Fri, 17 Jul 2020 05:28:02 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0746C08C5C0 for ; Fri, 17 Jul 2020 02:28:02 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id f2so10248128wrp.7 for ; Fri, 17 Jul 2020 02:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=IDRMoK9XAqR3KP28NyAj73nC8S++fY+3q8RW1Xp505E=; b=aUuIOdSl1Hj52p0XnwvTfGJv9BPtvFdL8zLQrtkTSwIDw2JYb3HK83DDvrMtVnhXDc eIf/lbmn+YLu0T7EVirEA+aGzoUXS9v86RVDH8na4723Hec1IskpkZmj9g3JUVx7lmZc 7rx8Is9uwbAulqVYWR8hCQo/QMUrlBHHYy9Vs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=IDRMoK9XAqR3KP28NyAj73nC8S++fY+3q8RW1Xp505E=; b=YAf9FTKm7LkgRmpiMUZsIiwum8jsWzKDtNJ12SnGcGt6yFiX+xO6kduNNFYofSe4Bu t5hYxuCBWY59pNwUMkLbDgun/ImhpHh4rGSa6Ky9nwof9zt/LfpyXW9V66akssLxGtYK Zr3dVQLVCt815UZft7WONJFv9/2i3SSXLgc3tsEmNYFaJ08OK9SlvqQTUWCqnMknHl1x toCfi/ZJE9TAu8evHdHdJ59Bcq8lD3+zmy5z8bfqPnMb4JwrEk6dISYlZmtRUS2M6PhF z2hAIjd/BVgFEXNpY8GGhtNOh7osSFRzrWYSipmENu61a+9D8+wCRKewgYPGWObEKuvA JEcg== X-Gm-Message-State: AOAM530onF8KJoKi9eS2p4RcMYrPCcJ0bAQ9wXaotwbMB5UDYGt+hshw R8y91Za7OZZRW/KOEGdP+GYbAQ== X-Received: by 2002:adf:8b5a:: with SMTP id v26mr9226933wra.165.1594978081123; Fri, 17 Jul 2020 02:28:01 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l8sm13287743wrq.15.2020.07.17.02.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2020 02:28:00 -0700 (PDT) Date: Fri, 17 Jul 2020 11:27:58 +0200 From: Daniel Vetter To: Lucas Stach Cc: Daniel Vetter , Philipp Zabel , Laurentiu Palcu , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Laurentiu Palcu , dri-devel , Linux ARM , devicetree , Guido =?iso-8859-1?Q?G=FCnther?= , lukas@mntmn.com, Linux Kernel Mailing List Subject: Re: [PATCH v5 0/4] Add support for iMX8MQ Display Controller Subsystem Message-ID: <20200717092758.GR3278063@phenom.ffwll.local> Mail-Followup-To: Lucas Stach , Philipp Zabel , Laurentiu Palcu , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Laurentiu Palcu , dri-devel , Linux ARM , devicetree , Guido =?iso-8859-1?Q?G=FCnther?= , lukas@mntmn.com, Linux Kernel Mailing List References: <20200709164736.18291-1-laurentiu.palcu@oss.nxp.com> <3c03afff3256ec36e12b9d9408830fbb4853f982.camel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.6.0-1-amd64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 11:12:39AM +0200, Lucas Stach wrote: > Am Freitag, den 17.07.2020, 10:59 +0200 schrieb Daniel Vetter: > > On Fri, Jul 17, 2020 at 10:18 AM Lucas Stach wrote: > > > Hi Laurentiu, > > > > > > Am Donnerstag, den 09.07.2020, 19:47 +0300 schrieb Laurentiu Palcu: > > > > From: Laurentiu Palcu > > > > > > > > Hi, > > > > > > > > This patchset adds initial DCSS support for iMX8MQ chip. Initial support > > > > includes only graphics plane support (no video planes), no HDR10 capabilities, > > > > no graphics decompression (only linear, tiled and super-tiled buffers allowed). > > > > > > > > Support for the rest of the features will be added incrementally, in subsequent > > > > patches. > > > > > > > > The patchset was tested with both HDP driver (in the downstream tree) and the upstream > > > > MIPI-DSI driver (with a couple of patches on top, to make it work correctly with DCSS). > > > > > > I think the series (minus 3/5 and minor correction to the DT binding) > > > is fine to go in now. So just some formal questions: are you going to > > > maintain this driver in upstream? If so we should add a MAINTAINERS > > > entry to that effect. I can offer to act as a reviewer in this case. > > > > > > How do you intend to merge this? IMO pushing this through drm-misc > > > seems like the right thing to do. If you agree I can help you get this > > > applied. If you are going to maintain the driver on your own, I think > > > you should then apply for commit rights to drm-misc. > > > > drm/imx isn't listed yet as under the drm-misc umbrella, maybe we > > should put the entire collective of imx drivers under drm-misc? Or > > maybe it's just an oversight that the git repo isn't specified in the > > MAINTAINERS entry. Also maybe we should add the pengutronix kernel > > team alias there too? > > drm/imx was exclusively the IPUv3 up until now, which is in fact > maintained outside of drm-misc in its own git tree. This has worked > quite well in the past so even though IPUv3 doesn't see a lot of churn > these days the motivation to change anything to this workflow is quite > low. And yes, the git tree is missing from the MAINTAINERS entry. > > For the DCSS driver, if it's going to be maintained by NXP, I figured > it might be easier for Laurentiu to push things into drm-misc than set > up a separate public git tree. But IMHO that's fully up to him to > decide. /me puts on maintainer hat Much prefer drm-misc over random people playing maintainer and fumbling it. I think the reasonable options are either in the current imx tree, or drm-misc. Standalone tree for these small drivers just doesn't make much sense. -Daniel > > Regards, > Lucas > > > -Daniel > > > > > > > Regards, > > > Lucas > > > > > > > Thanks, > > > > Laurentiu > > > > > > > > Changes in v5: > > > > * Rebased to latest; > > > > * Took out component framework support and made it a separate patch so > > > > that people can still test with HDP driver, which makes use of it. > > > > But the idea is to get rid of it once HDP driver's next versions > > > > will remove component framework as well; > > > > * Slight improvement to modesetting: avoid cutting off the pixel clock > > > > if the new mode and the old one are equal. Also, in this case, is > > > > not necessary to wait for DTG to shut off. This would allow to switch > > > > from 8b RGB to 12b YUV422, for example, with no interruptions (at least > > > > from DCSS point of view); > > > > * Do not fire off CTXLD when going to suspend, unless it still has > > > > entries that need to be committed to DCSS; > > > > * Addressed Rob's comments on bindings; > > > > > > > > Changes in v4: > > > > * Addressed Lucas and Philipp's comments: > > > > * Added DRM_KMS_CMA_HELPER dependency in Kconfig; > > > > * Removed usage of devm_ functions since I'm already doing all the > > > > clean-up in the submodules_deinit(); > > > > * Moved the drm_crtc_arm_vblank_event() in dcss_crtc_atomic_flush(); > > > > * Removed en_completion variable from dcss_crtc since this was > > > > introduced mainly to avoid vblank timeout warnings which were fixed > > > > by arming the vblank event in flush() instead of begin(); > > > > * Removed clks_on and irq_enabled flags since all the calls to > > > > enabling/disabling clocks and interrupts were balanced; > > > > * Removed the custom atomic_commit callback and used the DRM core > > > > helper and, in the process, got rid of a workqueue that wasn't > > > > necessary anymore; > > > > * Fixed some minor DT binding issues flagged by Philipp; > > > > * Some other minor changes suggested by Lucas; > > > > * Removed YUV formats from the supported formats as these cannot work > > > > without the HDR10 module CSCs and LUTs. Will add them back when I > > > > will add support for video planes; > > > > > > > > Changes in v3: > > > > * rebased to latest linux-next and made it compile as drmP.h was > > > > removed; > > > > * removed the patch adding the VIDEO2_PLL clock. It's already applied; > > > > * removed an unnecessary 50ms sleep in the dcss_dtg_sync_set(); > > > > * fixed a a spurious hang reported by Lukas Hartmann and encountered > > > > by me several times; > > > > * mask DPR and DTG interrupts by default, as they may come enabled from > > > > U-boot; > > > > > > > > Changes in v2: > > > > * Removed '0x' in node's unit-address both in DT and yaml; > > > > * Made the address region size lowercase, to be consistent; > > > > * Removed some left-over references to P010; > > > > * Added a Kconfig dependency of DRM && ARCH_MXC. This will also silence compilation > > > > issues reported by kbuild for other architectures; > > > > > > > > Laurentiu Palcu (5): > > > > drm/imx: compile imx directory by default > > > > drm/imx: Add initial support for DCSS on iMX8MQ > > > > drm/imx/dcss: add component framework functionality > > > > dt-bindings: display: imx: add bindings for DCSS > > > > arm64: dts: imx8mq: add DCSS node > > > > > > > > .../bindings/display/imx/nxp,imx8mq-dcss.yaml | 84 ++ > > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 23 + > > > > drivers/gpu/drm/Makefile | 2 +- > > > > drivers/gpu/drm/imx/Kconfig | 2 + > > > > drivers/gpu/drm/imx/Makefile | 1 + > > > > drivers/gpu/drm/imx/dcss/Kconfig | 9 + > > > > drivers/gpu/drm/imx/dcss/Makefile | 6 + > > > > drivers/gpu/drm/imx/dcss/dcss-blkctl.c | 70 ++ > > > > drivers/gpu/drm/imx/dcss/dcss-crtc.c | 219 +++++ > > > > drivers/gpu/drm/imx/dcss/dcss-ctxld.c | 424 +++++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-dev.c | 314 +++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-dev.h | 177 ++++ > > > > drivers/gpu/drm/imx/dcss/dcss-dpr.c | 562 ++++++++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-drv.c | 183 ++++ > > > > drivers/gpu/drm/imx/dcss/dcss-dtg.c | 409 +++++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-kms.c | 185 ++++ > > > > drivers/gpu/drm/imx/dcss/dcss-kms.h | 43 + > > > > drivers/gpu/drm/imx/dcss/dcss-plane.c | 405 +++++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-scaler.c | 826 ++++++++++++++++++ > > > > drivers/gpu/drm/imx/dcss/dcss-ss.c | 180 ++++ > > > > 20 files changed, 4123 insertions(+), 1 deletion(-) > > > > create mode 100644 Documentation/devicetree/bindings/display/imx/nxp,imx8mq-dcss.yaml > > > > create mode 100644 drivers/gpu/drm/imx/dcss/Kconfig > > > > create mode 100644 drivers/gpu/drm/imx/dcss/Makefile > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-blkctl.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-crtc.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ctxld.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dev.h > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dpr.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-drv.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-dtg.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-kms.h > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-plane.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-scaler.c > > > > create mode 100644 drivers/gpu/drm/imx/dcss/dcss-ss.c > > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch