Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1839064ybh; Fri, 17 Jul 2020 02:33:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwS4JiHD2aI6jH5tYwinmWU4/jL77ZCe1ZR2zuqwtn5ng1E/WAT7KUarYCraAJTUSfZVIIX X-Received: by 2002:aa7:c80f:: with SMTP id a15mr8031683edt.299.1594978431836; Fri, 17 Jul 2020 02:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594978431; cv=none; d=google.com; s=arc-20160816; b=F2LJ6MQ3PCWjA9K6yohC3mLUTauB4Pg/hNhl2maRiHwElKxOWnUS2arwjnEfEDlj3u M09svWrZIuFBb8qLBLS+IWYLJEh/9o1oGaXe9jJQviysQn89PJ9EFMkSMQ6+hScTLRh/ XiGoWJG1qkTc++USnvTnRrocA6KNwDBaQrObsOUqLOUjM+x4lKkMJ36z/cDd/k6NmPUz KKt3j529cwG1HmK/SLwJWJY2TVTY/s8nbOc6zjPOliMIhlQDlki9YMrnKgD6L3OXS3OJ PNF9jEqRLGlexe1eo2QXLoxQqTmkGKZ9EoxocfBD0oHvyEzYCDwTiXML+Di2SSkAMD6B PVRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=8JE8Gvv4RB/gs/MAI8dbxdwbA+OZGm7MQq6LvUxR/fo=; b=Kx2wV18bMI9b5aurvCwpVioPBtKj0OHoWXkxLtRhlbYU6U1xT5oHZjsk40hZczh5Dp Hm5015s4dKZkr3MIHwAddgKolqK1FzMNumvCBRZPQemFULvSZjnaJUZpkMP53lCbOqbc tJnpGR6GUgzX3pTSp2sCza8ncUeFmFgxxqIi/tigAQpibJ53kE9nWrb88Vccm2vBpfUM L1zTgAIBCv56DG7VqKrZHFQh/s1zEPteSFau3w8DZ1si8rZvKETJam2GYId+AQFOEZyw J+YAOH6SVsjI/oZ4qTGakeqtjWcpPYNglfVcyp9EsJmnK6xyvi6x3FFGiHc2L3rVA/Cz JtTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hBV4cO6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v12si4700224ejc.292.2020.07.17.02.33.27; Fri, 17 Jul 2020 02:33:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=hBV4cO6S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgGQJa7 (ORCPT + 99 others); Fri, 17 Jul 2020 05:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbgGQJa7 (ORCPT ); Fri, 17 Jul 2020 05:30:59 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1ED0C061755; Fri, 17 Jul 2020 02:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8JE8Gvv4RB/gs/MAI8dbxdwbA+OZGm7MQq6LvUxR/fo=; b=hBV4cO6S9PgOZBlKCRjzAJL6no Rw3QRuDlekzAwQ0JYQs5UINo17RGnHq2jRutA4fH/zxABb1BgsB+fCG80CtP39CHIN8CxAK3aLfje Jq2TleBWWjxtrLhGevYeWUNSHyYLsQux8xKQ07MRbf3y0hXK87ujztGJ6Fru6vZHIKqGXKI/GYvQE KulTU8LViEwzU7/jwhmNdZ8w+NcNaNvJsPrY9OmksMfz7yVDxHl+GRUoVJNqI6qXeL1QWF4MNCosl RF63zB0pzpZ0dBXeCyXrSCuPZYugS/oNE/PbL4hiazMYViBVB5hFMqhlCt45WvfNb/rZX1ToQC1ks tEQpBQ5A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwMhX-0006wo-AQ; Fri, 17 Jul 2020 09:30:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 624C43003D8; Fri, 17 Jul 2020 11:30:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 4B38729CF6F54; Fri, 17 Jul 2020 11:30:41 +0200 (CEST) Date: Fri, 17 Jul 2020 11:30:41 +0200 From: Peter Zijlstra To: ira.weiny@intel.com Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski , Dave Hansen , x86@kernel.org, Dan Williams , Vishal Verma , Andrew Morton , Fenghua Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC V2 17/17] x86/entry: Preserve PKRS MSR across exceptions Message-ID: <20200717093041.GF10769@hirez.programming.kicks-ass.net> References: <20200717072056.73134-1-ira.weiny@intel.com> <20200717072056.73134-18-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717072056.73134-18-ira.weiny@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 12:20:56AM -0700, ira.weiny@intel.com wrote: > +static void noinstr idt_save_pkrs(idtentry_state_t state) noinstr goes in the same place you would normally put inline, that's before the return type, not after it.