Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1910558ybh; Fri, 17 Jul 2020 04:45:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhYayWd8X4xbuMUolouQNdy73T7o5/Bm9sy28dT6AvZ3l1zR/jglimiNK3liYzRkKul1dJ X-Received: by 2002:aa7:c816:: with SMTP id a22mr8925268edt.28.1594986337439; Fri, 17 Jul 2020 04:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594986337; cv=none; d=google.com; s=arc-20160816; b=DevkS040+PCbftoHsKNAaKynRYygubW5XNF+NFHYfAQRLtvkNZrg0QQgGMs2YtVLeQ okXIkvo7yc+KIWllVUFKWzeb9Q8OOCEUTfeARggbGHTxRE/eLlj0p8NEyvjY/tDh2rct ODQq1kex0GD1wy/iE0/IUkayFcJMMdL++LlMGJ07/N8ouNa3UzbMZ3Fk2AFeDifTJpDw de87w0BnldtT1UpRK0USuam661zHZPHbBZAbgBOtiPmpvLM/8jZChIXG29EnaZDwMvQK bJIOzH0I6fTpdQyDAS3Ofr9YpB+8DLeCAlZkSR8wfwcaO2S9D+e4ae3PPhKVr9k5iFWN lLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=Rf/s0mYtz9sd60TQt0FeXPq64UMcju7FnUHxY/02Bno=; b=tQXbUk7HoJwFsbim/migbn9trUpcChONRTl7wn7I4tBIImEy+9DuYC8RMHfss/J1VP +RL9lOWibwehZ7pqWHXB+yoWnNWH6KeIGQIU+tM4l2t8TKN98Ge44xzgwQc+ZG8XWeNa 1fz2Jit1gByFC4p5PlHt/ywYVPFV0oH4haiKE7hQ8p92SGvtG+OhntZknOe2oa8aCjyt WYpFU3/qUqcWizNMB8K5hQKVwTStLTMfKmTIfq5BLkQ8smU8odEVusM6XhXrVz0k6KuH D01PKrXiUjESeh0g6lodpwNi9d4DTm8S1UAGWkvjY59Fpw5U2dN7G7/DDW6v01tYw34n P5lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r5si5303590edh.198.2020.07.17.04.45.15; Fri, 17 Jul 2020 04:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbgGQLpF (ORCPT + 99 others); Fri, 17 Jul 2020 07:45:05 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:38979 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726446AbgGQLpD (ORCPT ); Fri, 17 Jul 2020 07:45:03 -0400 X-IronPort-AV: E=Sophos;i="5.75,362,1589209200"; d="scan'208";a="52406122" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 17 Jul 2020 20:45:01 +0900 Received: from localhost.localdomain (unknown [10.166.252.89]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 466964267DBC; Fri, 17 Jul 2020 20:45:01 +0900 (JST) From: Yoshihiro Shimoda To: kishon@ti.com, vkoul@kernel.org Cc: wsa+renesas@sang-engineering.com, geert+renesas@glider.be, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH v3 2/2] phy: renesas: rcar-gen3-usb2: exit if request_irq() failed Date: Fri, 17 Jul 2020 20:44:57 +0900 Message-Id: <1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1594986297-12434-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1594986297-12434-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org To avoid unexpected behaviors, it's better to exit if request_irq() failed. Suggested-by: Vinod Koul Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas/phy-rcar-gen3-usb2.c index 5087b7c..e34e447 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -419,8 +419,10 @@ static int rcar_gen3_phy_usb2_init(struct phy *p) INIT_WORK(&channel->work, rcar_gen3_phy_usb2_work); ret = request_irq(channel->irq, rcar_gen3_phy_usb2_irq, IRQF_SHARED, dev_name(channel->dev), channel); - if (ret < 0) + if (ret < 0) { dev_err(channel->dev, "No irq handler (%d)\n", channel->irq); + return ret; + } } /* Initialize USB2 part */ -- 2.7.4