Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1949326ybh; Fri, 17 Jul 2020 05:49:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2LJR6OfxtF9Ryse4dw0uNWfSCRjLyqn7294bhe4w1KHYqNsUaPZ8TusxIVilnC6yj6Fhk X-Received: by 2002:a17:906:1b0a:: with SMTP id o10mr8464395ejg.463.1594990181145; Fri, 17 Jul 2020 05:49:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594990181; cv=none; d=google.com; s=arc-20160816; b=sSRLbTmAz0WhjUG9yEyd+MZuXdqOjWcgT5ymdpKdxIs3NS9t9pUqAulNnnOJ3l+bJb xsya9bhb63m78ulHaNLbthUQB8bIIIXFZGw398EesXse/11sFnVn2oxqYXJbiPTghY3B XjTzFfvbdW/hqmmeC/ACGZOoA+6qrsWhQyRXTdCmfUFHkP2pYGomBeNB6sFHwHUfrZBP Hnks2FEmNqwgMYFhMduTDCx3y2Z/dJ3+ajUHbLQOGkQ+cxGGCQ6SIU/lvx8VrKddTXrK njh9hYFJwkVNBP5DLU/AEmlbNScU0H1CW4NnFEPzAcgMGfSckGOtL+euOTbIxxvqeEh3 KtUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=bsE8DiPTGPWy9XN1ll7+4zwOuGupsjnWLl5U7dyVOIw=; b=IKY9M0zmkB1zgphRFZ/oYW/zc7hUfOyiTOU3fkYrb8TjQMofBIclxKBaRNzKl6G8+q CLxc9Rz9R0w7OpARSg7IBXHwcQEj2JtKbUa1KXcTvW1ZNUZpx0EIjH9C5ixIQ4W4wRbg zPxjMtIDCx40TrJAaobWxBFXTPnhLgseQ2MwhB+CUx2uD9ZMC+/B5iKpLNPn59Z/UJLq X/bRiE8Ul5sA1ISXRPjvS7pzxn9ZvR0E/vN7WT6dYkofz9dWbyqj/uEtrl0ri8y6e3Oq nViVImjkQKg2D+Fu2QHv5VO5A7vEcJTjbPzGNYgYKoEAQy9vgrACxqQk1Ui+g4JLe+D/ kHmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2uJXQ1Kf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w9si4984257edr.171.2020.07.17.05.49.18; Fri, 17 Jul 2020 05:49:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2uJXQ1Kf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726848AbgGQMtF (ORCPT + 99 others); Fri, 17 Jul 2020 08:49:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:50488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbgGQMs7 (ORCPT ); Fri, 17 Jul 2020 08:48:59 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7118B207FB; Fri, 17 Jul 2020 12:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594990139; bh=5POnxabUMyqHA1KxDC3Te6qQKnu8fFa8/yigj7vMA2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2uJXQ1KfkRiG4WbZZf4pM/IYginKG2nTtWy/qrZp7ICtuC25ONpKgTlR0nhflNE5t u4nTdxiavRPloJYgVH1tyKiL+mVOXDqf9h5PcQVnPU6JCzvQPhm+Q1mFa8Ey1vj8MU AugpzmI4sHeoRDoyLqhcsAhurpb+Cu5GEF3pqqBM= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jwPnO-00Ccsm-0z; Fri, 17 Jul 2020 13:48:58 +0100 From: Marc Zyngier To: Alexandre Torgue , Jason Cooper , Thomas Gleixner , Zenghui Yu Cc: linux-kernel@vger.kernel.org, marex@denx.de, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, wanghaibin.wang@huawei.com Subject: Re: [PATCH] genirq/irqdomain: Remove redundant NULL pointer check on fwnode Date: Fri, 17 Jul 2020 13:48:49 +0100 Message-Id: <159499001592.546505.17916680802608483979.b4-ty@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200716083905.287-1-yuzenghui@huawei.com> References: <20200716083905.287-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: alexandre.torgue@st.com, jason@lakedaemon.net, tglx@linutronix.de, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, marex@denx.de, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jul 2020 16:39:05 +0800, Zenghui Yu wrote: > The is_fwnode_irqchip() helper will check if the fwnode_handle is empty. > There is no need to perform a redundant check outside of it. Applied to irq/irqchip-5.9, thanks! [1/1] genirq/irqdomain: Remove redundant NULL pointer check on fwnode commit: 47903428b0e9db7a6251aa696fd1b2fc5de98545 Cheers, M. -- Without deviation from the norm, progress is not possible.