Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1980668ybh; Fri, 17 Jul 2020 06:33:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpQCJdqZYZk1iAR/GG9zKTdrOLK4ni9x3JeftbxoxtE1IQG6sfvb7pEm5ng54NVTrTuGCs X-Received: by 2002:a17:906:ce3c:: with SMTP id sd28mr8238715ejb.382.1594992797416; Fri, 17 Jul 2020 06:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594992797; cv=none; d=google.com; s=arc-20160816; b=bOhoMtczPcK9Sb2PaD6Xhn8ND0/VdWkFsxC33/ujkfifRHlXbaKVQGoKcKl6uh/P4r S+pIUr24pJdfSi/zXBQfnmCNfLdvPEDZTnFe9O8dr1FjhSNwUlC3Rp1gL3ogMAXNInRS WqzD9tIEs0Z+NEn6FkS6r3fIN0QMpxvNVDQd429PH+6R5AaIylfqQVzFbvIdMP948KzJ /6hTk+rjDE3xBYZCrU4sE6fREXcn8WsklXo/F6bGFSsVtJhCVptN4/+QRJR9E2dB8sfE 33dPFF2GtL/ptLt5mll/X2+QaXSuU6bQxMYxpkq25xDYMIDMAqFoRDiiJO9GoC+gundL gGHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=i8u41iPJxXK9FTGgItdBbgPW6UUUoKzYd1anGp6xt94=; b=ER0fe+YENkDSj7C849zpd8KBnT122LHn1CdGJa4weq7Xb5xDkCRWDPVXkbQ5jomUuw Pqgo32GPk3laZHqhMLqRsPQaT7ViRhVYWFVVfr2xet7MhLQe2IEZOOimMtx0mjDFKbkV aMIooA1TE9Qgk2wzKJVV+1U3iPO/bTvDn4objGrGTM6YbHftIQkNTYWJw7JYmvGjmzPS JlH/J46D0NzKBQjA2ik8jGlP/BkhD2sxuaLsWFsft7MKgAQYreqHMm8ZyhoGEF+p/z9m xCBJqXpQ507y9eKmc6pWvzkUZff4d8t9+qRbD5/mAbIjcTRTkeUGDFT0HhyCUpyqxK90 2HOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JTxVJnfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r9si5187271edm.321.2020.07.17.06.32.55; Fri, 17 Jul 2020 06:33:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=JTxVJnfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbgGQNbA (ORCPT + 99 others); Fri, 17 Jul 2020 09:31:00 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:39678 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726856AbgGQNar (ORCPT ); Fri, 17 Jul 2020 09:30:47 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06HDUEXW052070; Fri, 17 Jul 2020 08:30:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1594992614; bh=i8u41iPJxXK9FTGgItdBbgPW6UUUoKzYd1anGp6xt94=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=JTxVJnfYZWd0xrNzDVBf77IYGMFxJP1VBOxqXCplc8UC4q4haODryGmYjXPqJd2Ki HXkeihj1YUtQPBd3HgWaWdnhmSgRNBTLHG4HuZmGwMaqpj2PcVKd9SsjBIQHGYdFnU vlzHNFDtjxwMQGue34LrFcdO0YdM3waNHiMGakVU= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 06HDUE8K074823 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Jul 2020 08:30:14 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 17 Jul 2020 08:30:14 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 17 Jul 2020 08:30:14 -0500 Received: from sokoban.bb.dnainternet.fi (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06HDU5Lf051528; Fri, 17 Jul 2020 08:30:13 -0500 From: Tero Kristo To: , , CC: , Subject: [PATCHv4 4/4] watchdog: rti-wdt: balance pm runtime enable calls Date: Fri, 17 Jul 2020 16:29:58 +0300 Message-ID: <20200717132958.14304-5-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200717132958.14304-1-t-kristo@ti.com> References: <20200717132958.14304-1-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PM runtime should be disabled in the fail path of probe and when the driver is removed. Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support") Signed-off-by: Tero Kristo Reviewed-by: Guenter Roeck --- drivers/watchdog/rti_wdt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c index 7cbdc178ffe8..705e8f7523e8 100644 --- a/drivers/watchdog/rti_wdt.c +++ b/drivers/watchdog/rti_wdt.c @@ -303,6 +303,7 @@ static int rti_wdt_probe(struct platform_device *pdev) err_iomap: pm_runtime_put_sync(&pdev->dev); + pm_runtime_disable(&pdev->dev); return ret; } @@ -313,6 +314,7 @@ static int rti_wdt_remove(struct platform_device *pdev) watchdog_unregister_device(&wdt->wdd); pm_runtime_put(&pdev->dev); + pm_runtime_disable(&pdev->dev); return 0; } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki