Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1988551ybh; Fri, 17 Jul 2020 06:45:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywMN/Xrlvh5ih+RC77obnsY22xULqCSsBKn5hk0v7voD/GQTBz5/7deKXO/qSM7G2CPlyv X-Received: by 2002:a05:6402:1d3a:: with SMTP id dh26mr9395327edb.349.1594993516885; Fri, 17 Jul 2020 06:45:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594993516; cv=none; d=google.com; s=arc-20160816; b=K2dt0rCpHDNAWs2XlrL6pJGq14zjw+j3KvrmRYbLDwXvn+ltxUrbk52hbIRZaTkriP UoqBW+WmAiUIxaNxRQ+jq8S2VtYJWtAeaJdG0c9xePJ/IhBXjV9pjN9cZ108QWVJtnTV raXQv1+2JcrsX5oLc67xid8t5InZZzttx1PQyRu2ZcJjB8Ql0tUY/TAASnJqmzcE7XAk 5Iwko5Q51Dm8oDehK5QpM8Apek+epgMsEP+CLR51mD4lNtbS/j+i8//5I3/bTUT45zLe oFBz02Ry8Bs4+87ahEAnp6GQMIWEUZOO7m6+83wIXj8Yu+71sus35LLW6rEmLqOJl+tQ xXSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=1cUJdFz7tKiJruju+faOa4LG72A7NyvpvJU3G6JjCco=; b=vh1RLNYIXT3eUw0PXoKZRPu1t0NZMoKQW5b7dAmeVNOK4/nHWSntSvzRsAeZzP9+Wz xeRJV7Qqb24gWtQDfp/eayHCr8dT6Xn+1qiuO7YuBueYTTzxrKI97lfJ9V/Vl0EORQlb l6NILIpHMMAMG0MvJ91hHE1OTmQ5WEL4ZIDrl0ZzDMf4ydVb5OzMWeFHcqyOQlb9rNoa r/fP9kimvkj2G8tHFQ/sGLALIGaKBb8wLESWK6t+ZB7uV4FbKYE5LqByBLGFuLvfP9ZX eq+LU2QFqSQzB4T0KctyVX7rpzlxAQkxqXDKaaClpSD8vFA4BBuyp8lcF/TFcZyju7sF Aulw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cZMposf8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e10si5237749edq.65.2020.07.17.06.44.54; Fri, 17 Jul 2020 06:45:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cZMposf8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbgGQNob (ORCPT + 99 others); Fri, 17 Jul 2020 09:44:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgGQNo1 (ORCPT ); Fri, 17 Jul 2020 09:44:27 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 435FFC08C5C0 for ; Fri, 17 Jul 2020 06:44:27 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id b30so3778299lfj.12 for ; Fri, 17 Jul 2020 06:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1cUJdFz7tKiJruju+faOa4LG72A7NyvpvJU3G6JjCco=; b=cZMposf8Bdnm371NM5sPZlM/Is0F5t0m+S9ezxyz5F0ewN5dQ4z9Gz4kV19AV/oGv7 AHwH4yY0xZA85B8vd03RqF+47bHBNo+zh9Gn0WtV4oYw7yuzYJg94UEpD+yhv+YuCIFk DBN11Ba0xu3uapZyMG133CrLeSV5g0Md5zrsihIFZYDxIvcKlFifAd4KzKRbmJ8fUs13 nW3qsfXWmjnoRjIk8xtLhgfZyupBJncmE7HMrBGg3zdfRQpIbiS/0fkEZv6YRmM10hjo 1IDc22DAV+kyFgNesZmJCV92yMZpf8ajo9bFcrPoKc3k2puE/9sa3gjwE+Tl3cnJflBQ 2lQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1cUJdFz7tKiJruju+faOa4LG72A7NyvpvJU3G6JjCco=; b=b6E3ck6UtTPT1lAcNyXHBj9yPqnF4og2o3Fq5iWZ+WWeMbj1vBosP6H1bSy0Pnz7zN hYG2djlryWlcZ6q0pY8QK6vI7tpx+hsJcoEbUJMbFkfkvMb2O8tVwHR6NYmoSGg4n6TT WgRFM+C+uU9t98VbISdUCVX/7Q+5GV0w9QBDDfeyuIjBHaWZwFuvqL4jTsIJnk26whAI E5aD2JSkAe0zHhDNkCxk2lcFcQRqJnGNUTuHIbxCHqsj2NnkwoZDBangTo0KH2yHjmdK puvRQ9DKWz9wIqGDPv7rLgY0GzDsJRjx+6h82YIYmE1wZTRKFOTzzqHQC2baDHowHjJ5 Uj6g== X-Gm-Message-State: AOAM5312DlrDkibIKdkBLH8LMc/vuGBYQZO4iOleK5PtkSGixkFbLGAa 4Z3MLZEDRKeLLzhDATgvGvxHIgwz2T8bWyauL+MlDw== X-Received: by 2002:a19:203:: with SMTP id 3mr4730864lfc.77.1594993465647; Fri, 17 Jul 2020 06:44:25 -0700 (PDT) MIME-Version: 1.0 References: <1594164323-14920-1-git-send-email-Anson.Huang@nxp.com> <20200717121436.GA2953399@kroah.com> In-Reply-To: <20200717121436.GA2953399@kroah.com> From: Linus Walleij Date: Fri, 17 Jul 2020 15:44:14 +0200 Message-ID: Subject: Re: [PATCH 1/3] gpio: mxc: Support module build To: Greg KH Cc: Anson Huang , John Stultz , Russell King , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , Catalin Marinas , Will Deacon , Bartosz Golaszewski , "oleksandr.suvorov@toradex.com" , Adam Ford , Andreas Kemnade , "hverkuil-cisco@xs4all.nl" , Bjorn Andersson , Leo Li , Vinod Koul , Geert Uytterhoeven , Olof Johansson , Linux ARM , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , dl-linux-imx , Jon Corbet Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 2:14 PM Greg KH wrote: > So moving drivers to modules is good. If a module can be removed, even > better, but developers should not be lazy and just flat out not try at > all to make their code unloadable if at all possible. > > Does that help? Yeah it confirms my intuitive maintenance approach: developer submits modularization patch, I will be a bit inquisitive and "can't you attempt to make this thing unload too" and if they conclude that that is an unfathomable effort I will likely merge it anyway as very likely the kernel looks better after than before provided all build and test coverage stays the same as well. Thanks! Linus Walleij