Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 17 Jul 2020 18:07:27 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Frank Lee <frank@allwinnertech.com>
Cc:     robh+dt@kernel.org, wens@csie.org, tiny.windzz@gmail.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: gpio: =?utf-8?Q?sunxi=EF=BC=9Acreat?=
 =?utf-8?Q?e?= a DT header for Allwinner pin controller
Message-ID: <20200717160727.e6y5htg4sjd7bezi@gilmour.lan>
References: <20200715115412.2544-1-frank@allwinnertech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="g4g5nqohehjztih7"
Content-Disposition: inline
In-Reply-To: <20200715115412.2544-1-frank@allwinnertech.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--g4g5nqohehjztih7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

On Wed, Jul 15, 2020 at 07:54:12PM +0800, Frank Lee wrote:
> From: Yangtao Li <frank@allwinnertech.com>
>=20
> The sunxi gpio binding defines a few custom cells for its gpio specifier.
> Provide bank name for those.
>=20
> Signed-off-by: Yangtao Li <frank@allwinnertech.com>

Thanks for working on this, I wanted to do it at some point but it kept
getting pushed further into my todo list.

> ---
>  include/dt-bindings/gpio/sunxi-gpio.h | 29 +++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 include/dt-bindings/gpio/sunxi-gpio.h
>=20
> diff --git a/include/dt-bindings/gpio/sunxi-gpio.h b/include/dt-bindings/=
gpio/sunxi-gpio.h
> new file mode 100644
> index 000000000000..c692b4360da6
> --- /dev/null
> +++ b/include/dt-bindings/gpio/sunxi-gpio.h

So generally we've been using the compatible name as the file name. You
should follow that convention too, and since it was added with the A10,
using the A10 compatible.

> @@ -0,0 +1,29 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * GPIO definitions for Allwinner SoCs
> + *
> + * Copyright (C) 2020 Yangtao Li <frank@allwinnertech.com>
> + */
> +
> +#ifndef _DT_BINDINGS_SUNXI_GPIO_H
> +#define _DT_BINDINGS_SUNXI_GPIO_H
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +/* pio */
> +#define PA	0
> +#define PB	1
> +#define PC	2
> +#define PD	3
> +#define PE	4
> +#define PF	5
> +#define PG	6
> +#define PH	7
> +#define PI	8
> +
> +/* r-pio */
> +#define PL	0
> +#define PM	1
> +#define PN	2
> +
> +#endif /* _DT_BINDINGS_SUNXI_GPIO_H */

Maybe we can go one step further and use a macro to have something like
PIN(A, 12) ?

Maxime

--g4g5nqohehjztih7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXxHMvwAKCRDj7w1vZxhR
xZe7AP4nQk5JlNsOhlZTUs0MH0jwyCEnPkq2g+L9nrus/9DyhwEAmd2oehdBu15l
snwOPbBnvRy1RNcmSaPZpc/OO2hwcg0=
=ucxT
-----END PGP SIGNATURE-----

--g4g5nqohehjztih7--