Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2100392ybh; Fri, 17 Jul 2020 09:18:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1RhB0JUnSqaitE37IzG/9DTnykhHCOVKQEZ81XBNqfUvNQJC5pZ6C67TIQDk0vhIhPZz6 X-Received: by 2002:a17:906:6959:: with SMTP id c25mr9028322ejs.375.1595002681557; Fri, 17 Jul 2020 09:18:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595002681; cv=none; d=google.com; s=arc-20160816; b=FMcAQu16AM5NKpZy6eIWlQlO/fazJpMcX7Y1PkYWP3v1Q0lMBObfiwTMHDusMqbpVd kazV9YkYBb/dUic/1hlsyZhWZk/9hP1jbtqtzj31IhaYsayZr4W+OeMXhOp6LXfUob05 NRj8LSyR5uvWz0s+MX9Se2o1QWBc/JGKuwaas6ZpG7GhB3pLplZET92o3umxmXVV7W5D YyAdPD0OwGn4860ccuZk3B+W9EoYW+/U5DZEMloqlaSS2Yf9I+4ScozWXWqOY4hS2nir OihiG+wjyOWrKswKykA988NJaSGE/e/ukrba405TCXFrYUzV1yIpD8faSKvxN+gabMTo WFBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=bgZe9gjE6PUcJcj4lNG6cSUYfGk6Y0PBpe9s1qppvaQ=; b=khrQmJ75pJvURwRtqu3aTG2SgYtmYjDSJLtVnqgiw4z7m1wzGQgCWmEkJsM8iwj//r N35+h0mDAjrxlEan+tar6RVbSQDJJqSx+e4d/PrxddYXihlCEqM7rUbdJ/cZsCCpLjzJ HokONcK0IIBfsGJpPBLX/i5lfAFeSNaeOLlLqY3Vs7SxIXHQd3uSfPOiMIbVkxZ96RH4 4QSCzEjGh2B0zQ5jvoDwcKOlbDKYXf3lme4mLI3se3fHZMbdyNgMVDdwUm1L1iiLBhry aeoraSe+WtmzoBi5bo1CjvZdYV/7rEVsFkH7Ztz2rs5qNmVo44nkg/OBswBe7TVwdRk3 /meQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z27si6161071ejl.277.2020.07.17.09.17.37; Fri, 17 Jul 2020 09:18:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726755AbgGQQR3 (ORCPT + 99 others); Fri, 17 Jul 2020 12:17:29 -0400 Received: from foss.arm.com ([217.140.110.172]:43376 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726104AbgGQQR2 (ORCPT ); Fri, 17 Jul 2020 12:17:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A864B142F; Fri, 17 Jul 2020 09:17:27 -0700 (PDT) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB4FF3F68F; Fri, 17 Jul 2020 09:17:25 -0700 (PDT) Date: Fri, 17 Jul 2020 17:17:23 +0100 From: Qais Yousef To: Eugeniu Rosca Cc: Greg Kroah-Hartman , Alan Stern , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, Tony Prisk , Mathias Nyman , Oliver Neukum , linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, Sasha Levin , Andrew Gabbasov , Dirk Behme , Eugeniu Rosca Subject: Re: [PATCH 4.14 105/136] usb/ehci-platform: Set PM runtime as active on resume Message-ID: <20200717161639.37ptgbolborimcvs@e107158-lin.cambridge.arm.com> References: <20200623195303.601828702@linuxfoundation.org> <20200623195308.955410923@linuxfoundation.org> <20200709070023.GA18414@lxhi-065.adit-jv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200709070023.GA18414@lxhi-065.adit-jv.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eugeniu On 07/09/20 09:00, Eugeniu Rosca wrote: > Hello everyone, > > Cc: linux-renesas-soc > Cc: linux-pm [...] > After integrating v4.14.186 commit 5410d158ca2a50 ("usb/ehci-platform: > Set PM runtime as active on resume") into downstream v4.14.x, we started > to consistently experience below panic [1] on every second s2ram of > R-Car H3 Salvator-X Renesas reference board. > > After some investigations, we concluded the following: > - the issue does not exist in vanilla v5.8-rc4+ > - [bisecting shows that] the panic on v4.14.186 is caused by the lack > of v5.6-rc1 commit 987351e1ea7772 ("phy: core: Add consumer device > link support"). Getting evidence for that is easy. Reverting > 987351e1ea7772 in vanilla leads to a similar backtrace [2]. > > Questions: > - Backporting 987351e1ea7772 ("phy: core: Add consumer device > link support") to v4.14.187 looks challenging enough, so probably not > worth it. Anybody to contradict this? > - Assuming no plans to backport the missing mainline commit to v4.14.x, > should the following three v4.14.186 commits be reverted on v4.14.x? > * baef809ea497a4 ("usb/ohci-platform: Fix a warning when hibernating") > * 9f33eff4958885 ("usb/xhci-plat: Set PM runtime as active on resume") > * 5410d158ca2a50 ("usb/ehci-platform: Set PM runtime as active on resume") Thanks for investigating this. Alan, Greg, do you have any ideas? Let me know if there's anything I can help with. Thanks -- Qais Yousef