Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ExEDRUaHGDSQJBv7KkABN3109/kSYcksjtUtGUlgpOxkk+L1FMyzhmbEk6BNnjl6AE3yBep/vm
 ohEvaeKd6+ig==
IronPort-SDR: VlRttUfKtFlriv3Wt1LCem7s8+TEqk4AchpE2fphPijayi/xJUydLfysTX8xGKQZNNnZx+33wo
 NAMn8HwmFPhg==
From:   "Eads, Gage" <gage.eads@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Karlsson, Magnus" <magnus.karlsson@intel.com>,
        "Topel, Bjorn" <bjorn.topel@intel.com>
Subject: RE: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Topic: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
Thread-Index: AQHWWGU9Tth4ik4BzU63g7CSJsQmkakKx86w
Date:   Fri, 17 Jul 2020 18:18:46 +0000
Message-ID: <SN6PR11MB2574E9B6F6957D765BC18F29F67C0@SN6PR11MB2574.namprd11.prod.outlook.com>
References: <20200712134331.8169-1-gage.eads@intel.com>
 <20200712134331.8169-2-gage.eads@intel.com>
 <20200712155810.GC186665@kroah.com>
In-Reply-To: <20200712155810.GC186665@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b2509b2-1da2-4c31-feb3-08d82a7dd8e5
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2020 18:18:46.9906
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rhbGh+jB+MJY7sluxShvpZ4vZjgtz+03x7fk5/JwI07KwTakSt7yLAZ0nWp11cVsMmo3Rvb4w1jHaQIbqaadYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2880
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Sunday, July 12, 2020 10:58 AM
> To: Eads, Gage <gage.eads@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Karlsson, Magnus
> <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>
> Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver
>=20
> On Sun, Jul 12, 2020 at 08:43:12AM -0500, Gage Eads wrote:
> > +static int dlb2_probe(struct pci_dev *pdev,
> > +		      const struct pci_device_id *pdev_id) {
> > +	struct dlb2_dev *dlb2_dev;
> > +	int ret;
> > +
> > +	dev_dbg(&pdev->dev, "probe\n");
>=20
> ftrace is your friend.  Remove all of your debugging code now, you don't =
need
> it anymore, especially for stuff like this where you didn't even need it =
in the
> first place :(

I'll remove this and other similar dev_dbg() calls. This was an oversight o=
n my part.

I have other instances that a kprobe can't easily replace, such as printing=
 structure contents, that are useful for tracing the usage of the driver. I=
t looks like other misc drivers use dev_dbg() similarly -- do you consider =
this an acceptable use of a debug print?

Thanks,
Gage

>=20
> Same for everywhere else in all of these patches.  I'll stop reviewing no=
w,
> someone at Intel should have caught basic stuff like this before now, sad=
...
>=20
> greg k-h