Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200712131003.23271-1-madhuparnabhowmik10@gmail.com>
 <20200712131003.23271-2-madhuparnabhowmik10@gmail.com> <20200712160856.GW9247@paulmck-ThinkPad-P72>
 <CA+G9fYuVmTcttBpVtegwPbKxufupPOtk_WqEtOdS+HDQi7WS9Q@mail.gmail.com>
 <CAA42JLY2L6xFju_qZsVguGtXvDMqfCKbO_h1K9NJPjmqJEav=Q@mail.gmail.com> <20200717170747.GW9247@paulmck-ThinkPad-P72>
In-Reply-To: <20200717170747.GW9247@paulmck-ThinkPad-P72>
From:   Naresh Kamboju <naresh.kamboju@linaro.org>
Date:   Sat, 18 Jul 2020 00:35:12 +0530
Message-ID: <CA+G9fYvtYr0ri6j-auNOTs98xVj-a1AoZtUfwokwnvuFFWtFdQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage
To:     "Paul E. McKenney" <paulmck@kernel.org>,
        madhuparnabhowmik10@gmail.com
Cc:     Dexuan-Linux Cui <dexuan.linux@gmail.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Paolo Bonzini <pbonzini@redhat.com>, rcu@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        X86 ML <x86@kernel.org>, kvm list <kvm@vger.kernel.org>,
        frextrite@gmail.com, lkft-triage@lists.linaro.org,
        Dexuan Cui <decui@microsoft.com>, juhlee@microsoft.com,
        =?UTF-8?B?RGFuaWVsIETDrWF6?= <daniel.diaz@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Paul,

> I am not seeing this here.

Do you notice any warnings while building linux next master
for x86_64 architecture ?

> Could you please let us know what compiler
> and command-line options you are using to generate this?

We have two build systems one showing it as error and build breaks
and another one showing it as warning and build pass.
tool chain: gcc 9.3.0
build command:
make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Dx86 HOSTCC=3Dgcc
CC=3D"sccache gcc" O=3Dbuild

metadata:
    git_repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-ne=
xt.git,
    target_arch: x86,
    toolchain: gcc-9,
    git_short_log: aab7ee9f8ff0 (\Add linux-next specific files for 2020071=
7\),
    git_sha: aab7ee9f8ff0110bfcd594b33dc33748dc1baf46,
    git_describe: next-20200717,
    kernel_version: 5.8.0-rc5,

warning log,
--
make -sk KBUILD_BUILD_USER=3DTuxBuild -C/linux -j16 ARCH=3Dx86 HOSTCC=3Dgcc
CC=3D"sccache gcc" O=3Dbuild
#
In file included from ../include/linux/pid.h:5,
                 from ../include/linux/sched.h:14,
                 from ../include/linux/kvm_host.h:12,
                 from ../arch/x86/kvm/mmu/page_track.c:14:
../arch/x86/kvm/mmu/page_track.c: In function =E2=80=98kvm_page_track_write=
=E2=80=99:
../include/linux/rculist.h:727:30: warning: left-hand operand of comma
expression has no effect [-Wunused-value]
  727 |  for (__list_check_srcu(cond),     \
      |                              ^
../arch/x86/kvm/mmu/page_track.c:232:2: note: in expansion of macro
=E2=80=98hlist_for_each_entry_srcu=E2=80=99
  232 |  hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
../arch/x86/kvm/mmu/page_track.c: In function =E2=80=98kvm_page_track_flush=
_slot=E2=80=99:
../include/linux/rculist.h:727:30: warning: left-hand operand of comma
expression has no effect [-Wunused-value]
  727 |  for (__list_check_srcu(cond),     \
      |                              ^
../arch/x86/kvm/mmu/page_track.c:258:2: note: in expansion of macro
=E2=80=98hlist_for_each_entry_srcu=E2=80=99
  258 |  hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/x86/kvm/svm/svm.o: warning: objtool: svm_flush_tlb_gva()+0x12:
call without frame pointer save/setup
kernel/bpf/core.o: warning: objtool: ___bpf_prog_run.cold()+0x7: call
without frame pointer save/setup

ref:
https://gitlab.com/Linaro/lkft/kernel-runs/-/jobs/643978120


>                                                         Thanx, Paul

- Naresh