Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2221028ybh; Fri, 17 Jul 2020 12:12:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdFU9/ArmvzPqRVDF6Fa6pfiR1HPWghYr4nZT8Yb26FHKADAnDWF7Xu2n0FazHU5FadYPZ X-Received: by 2002:a17:906:1747:: with SMTP id d7mr9919325eje.39.1595013163316; Fri, 17 Jul 2020 12:12:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595013163; cv=none; d=google.com; s=arc-20160816; b=SlOZFD+i6zRpBxsBxeLVEd2ep7/kGVoxCqayG9Uv8Rg1HIj3VYLCE8W9WttBg6+FHb Lop35A+09RpRuvJeAh3mC4OezluVFwtoZ3gPeff3vqK7aYcwl31+x5OvoMyjOf+9aSVm EKxi2SnPqcLCZGMMxE8OmuRYeHqLu8/r50vkrjNO70ebBD/Uoy+cdbmZLCQIgRr77o0d XaWY/jdnItG94w1uA9co65Cg5mX+wi+kdrHBL2fN10NQLZOVtAmft5LFps0ld+mO3pKI Jyph+QEybZIqQABMCBascFS0Hd/opxUff/TC/ICFoVzbJbiDY8POZ2R+xL59H9d9PMpW 6hVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=DLvQ6chRzbjeKicuQdxuqVcpH3d1W/1R1Kay/NtRj70=; b=V6ZV65wSZc/4SWgRmbeVDi7EoBygSI2E3ExHbeYhKIZu1Q2AgLHs9d8FD2n7LM0F/d 6aCmqgyFq5s4+W6pAYN0uXWRirg9L1dMiMxduu+C3+48s96qSVTyNAQ4/94rM2rsHzCN vw3jItRivtuy5gou99BS6lx5/BqvBOv4aeYstLToXSXrF4KPqQXJ/zIxs9Y+1Fh84Tzr 9FSL007zCB3TFm8PYeaLrr8hgrfJRkUSin2RHM432f3fHpGLLm94jb6bwP/nIaTCM4w8 GphZTmkt8yvVlUjeb70aCzjE//z/mxWVvoGHPif4OBAlOmrnpqaXrI4NJivLoY3NXJVU O8oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=dNkIccMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t19si5394499ejx.443.2020.07.17.12.12.20; Fri, 17 Jul 2020 12:12:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=dNkIccMw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728634AbgGQTL7 (ORCPT + 99 others); Fri, 17 Jul 2020 15:11:59 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:1396 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728607AbgGQTL6 (ORCPT ); Fri, 17 Jul 2020 15:11:58 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 17 Jul 2020 12:10:58 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Fri, 17 Jul 2020 12:11:57 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Fri, 17 Jul 2020 12:11:57 -0700 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 17 Jul 2020 19:11:57 +0000 Received: from rnnvemgw01.nvidia.com (10.128.109.123) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 17 Jul 2020 19:11:57 +0000 Received: from skomatineni-linux.nvidia.com (Not Verified[10.2.163.115]) by rnnvemgw01.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Fri, 17 Jul 2020 12:11:56 -0700 From: Sowjanya Komatineni To: , , , , , , , , , CC: , , Subject: [PATCH v2 1/3] media: i2c: imx274: Fix Y_OUT_SIZE register setting Date: Fri, 17 Jul 2020 12:15:20 -0700 Message-ID: <1595013322-15077-1-git-send-email-skomatineni@nvidia.com> X-Mailer: git-send-email 2.7.4 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1595013058; bh=DLvQ6chRzbjeKicuQdxuqVcpH3d1W/1R1Kay/NtRj70=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: X-NVConfidentiality:MIME-Version:Content-Type; b=dNkIccMwSkcpJVG9TVvN1c8DqptyYAYHC0pojdxtG/ndu8jD1Aqq8KySS2156GZQm yngeqITKvsHwtyC2mPMbgIoU7I6NAAfkIR3cQD8BtywDat7iYArxf0NoScpyi9SlbM pMUY7U4PFSmgDiu39pU9LqEhyukAf2VhxjdYKUi1jFtIlymWLn7Y7HB3wUpYAZWJqk FLVNwWvdAlmJXbXy5zeU63P91/RarxpLqS8hNorSv25iXnI3FefRBmWj3t7FxlFbd4 1wR3HRZfgqhbsY6XDaelo7suvoDrmjeTShv0B0YG9M7chZ5jXhYugVQ6fVhFetF03x lfT3lqnadGRRg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As per Sony IMX274 Y_OUT_SIZE should be the height of effective image output from the sensor which are the actual total lines sent over MIPI CSI to receiver. So, Y_OUT_SIZE should be same as crop height and this patch fixes it. Signed-off-by: Sowjanya Komatineni --- drivers/media/i2c/imx274.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c index e6aa9f3..55869ff 100644 --- a/drivers/media/i2c/imx274.c +++ b/drivers/media/i2c/imx274.c @@ -1163,7 +1163,7 @@ static int imx274_apply_trimming(struct stimx274 *imx274) (-imx274->crop.top / 2) : (imx274->crop.top / 2); v_cut = (IMX274_MAX_HEIGHT - imx274->crop.height) / 2; write_v_size = imx274->crop.height + 22; - y_out_size = imx274->crop.height + 14; + y_out_size = imx274->crop.height; err = imx274_write_mbreg(imx274, IMX274_HMAX_REG_LSB, hmax, 2); if (!err) -- 2.7.4