Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] leds: add NCT6795D driver
To:     Pavel Machek <pavel@ucw.cz>, Alexandre Courbot <gnurou@gmail.com>
Cc:     Dan Murphy <dmurphy@ti.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-leds@vger.kernel.org
References: <20200713134114.137265-1-gnurou@gmail.com>
 <20200714223344.GA20740@amd>
 <CAAVeFuKomLcAue9rGXhK3Uc=H+v9ZLBA84Ozr_rZDRQMYeC=dg@mail.gmail.com>
 <17fe52a2-73ff-b547-8a59-5df009c929c8@gmail.com>
 <CAAVeFuJQCp7Fpqx3nUHMy29Jw1pLNoQtxRw3qxfEf3YKnrm0fw@mail.gmail.com>
 <20200717074410.GA8895@amd>
From:   Jacek Anaszewski <jacek.anaszewski@gmail.com>
Message-ID: <756fa49f-bf67-0447-cf45-1358b66c40f8@gmail.com>
Date:   Fri, 17 Jul 2020 21:25:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200717074410.GA8895@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/17/20 9:44 AM, Pavel Machek wrote:
> Hi!
> 
>>>>>> Add support for the LED feature of the NCT6795D chip found on some
>>>>>> motherboards, notably MSI ones. The LEDs are typically used using a
>>>>>> RGB connector so this driver creates one LED device for each color
>>>>>> component.
>>>>>
>>>>> Ok, let me take a look. What entries does it present in /sys?
>>>>
>>>> Right now these 3 directories in /sys/class/leds:
>>>>
>>>> nct6795d:blue:
>>>> nct6795d:green:
>>>> nct6795d:red:
>>>>
>>>> with the usual suspects `brightness` and `max_brightness` in each. I
>>>> am not 100% sure I got the names right so please let me know if that
>>>> is not correct.
>>>
>>> You miss LED function, that should be in the second section.
> 
> third section?

Ekhm, right.

> 
>> The reason for not having a function at the moment is that I took a
>> look at include/dt-bindings/leds/common.h and could not find any
>> function that could reasonably apply. This basically controls a RGB
>> connector on the motherboard which serves no particular function - you
>> can plug a RGB fan or anything else you want and control it in any
>> fashion. Is there a function that applies to this use-case?

According to common LED bindings you should propose a new function
if none of the existing ones fits your needs.

> This is normally used for motherboard lightning, right? I believe this
> is getting common on gaming boards, and we want common support for
> that.

I agree.

-- 
Best regards,
Jacek Anaszewski