Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2244641ybh; Fri, 17 Jul 2020 12:51:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1iwcHb0kxeA4qjYiJ/+eF1Y5OfKFxKNw/QOUl8btYBwn+7GQfQ2yrnPOMxw0P7vRvMuvj X-Received: by 2002:a17:906:1751:: with SMTP id d17mr9901816eje.140.1595015515386; Fri, 17 Jul 2020 12:51:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595015515; cv=none; d=google.com; s=arc-20160816; b=ynmdoce6jqlykSHDiI6tQHBgMSpbzzB+N3LU+jOg961gMLSkHlAweyOGpPh2tE1AtQ ow/da1DPD1F2N5txzjbI0bLPVrcb9hu0BRY00mPfZ11/J7GpSxWr14UCCDz5/a3gBvVW 1yv51HdOKUzoy6vAj3i6DdHrvPiygAOhuN2ojfjWVHrxF5NvllzqsrnbWJFVslL8YvL6 8RzDPfV3yijL/mYrXhqOOiOFQHT23Cx38JhRMYYEAGmT15M7lwF9hocSRJhP/xjbOr6l 8nNsIaTeTHe8uX0mmXVLQ4sNRUDZI9zv5f8IzO36Ea0bOOauCSF7tclArADukHA+Yv2M 61Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=xbUL9zfAFQCKFrEGjgJ3TOuDFPa5VYXsfzEpXTw7F5U=; b=rr+n1kH5U6K685VMha0BtwHq8hCDILi+razV4LeGdMKmlBLbSKuw8wxXhRl5i7/mGE vbPXSJg1IF3+weYEVXAbHOyrAXzZUKGi9WcfT2Hb9ZolTsD9To8YYMIlDumOMWENEdjc jfcNGuDAbdpCEtcX8Sf5EWS7WoE/CRtU++YO1LmaQEyX/i+gYqvtS5DtS+Q0w4cv5pWA hhbG5Cw6CCkBItAAb974C3tShXazUIxZ+Qgv9ER7iQuALKLozW4uPw49T2/s9cvyVLoF GFa7BTLLZEp+YhZGuOe7SZQjRl1vYqVgFABAZEmGdzdm56WqzhonfLqQudTFypDvNw7K xpVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z2si5892994ejc.595.2020.07.17.12.51.32; Fri, 17 Jul 2020 12:51:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728224AbgGQTs4 (ORCPT + 99 others); Fri, 17 Jul 2020 15:48:56 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:47402 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728022AbgGQTsz (ORCPT ); Fri, 17 Jul 2020 15:48:55 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 6268180501; Fri, 17 Jul 2020 21:48:51 +0200 (CEST) Date: Fri, 17 Jul 2020 21:48:49 +0200 From: Sam Ravnborg To: Laurentiu Palcu Cc: Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Lucas Stach , agx@sigxcpu.org, lukas@mntmn.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ Message-ID: <20200717194849.GA2369507@ravnborg.org> References: <20200717144132.2206-1-laurentiu.palcu@oss.nxp.com> <20200717144132.2206-3-laurentiu.palcu@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717144132.2206-3-laurentiu.palcu@oss.nxp.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=8AirrxEcAAAA:8 a=zm2rouQ-rTcRMPztwuMA:9 a=CjuIK1q_8ugA:10 a=ST-jHhOKWsTCqRlWije3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurentiu. On Fri, Jul 17, 2020 at 05:41:27PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > Some of its capabilities include: > * 4K@60fps; > * HDR10; > * one graphics and 2 video pipelines; > * on-the-fly decompression of compressed video and graphics; > > The reference manual can be found here: > https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM > > The current patch adds only basic functionality: one primary plane for > graphics, linear, tiled and super-tiled buffers support (no graphics > decompression yet), no HDR10 and no video planes. > > Video planes support and HDR10 will be added in subsequent patches once > per-plane de-gamma/CSC/gamma support is in. > > Signed-off-by: Laurentiu Palcu > Reviewed-by: Lucas Stach > --- .... return drm_bridge_attach(encoder, bridge, NULL, 0); .... The above code-snippet tells that the display-driver rely on the bridge to create the connector. Could this by any chance be updated to the new way where the display driver creates the connector - and thus passing DRM_BRIDGE_ATTACH_NO_CONNECTOR as the flags argument? What bridges would be relevant? To check that the reelvant bridges are already ported. Sam