Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 18 Jul 2020 01:04:31 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Scott Branden <scott.branden@broadcom.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Subject: Re: [PATCH v2] pwm: bcm-iproc: handle clk_get_rate() return
Message-ID: <20200717230431.4oj44cfnkhkd2o6z@pengutronix.de>
References: <20200717182512.26001-1-scott.branden@broadcom.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="5ahgp5eqlhd5enic"
Content-Disposition: inline
In-Reply-To: <20200717182512.26001-1-scott.branden@broadcom.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--5ahgp5eqlhd5enic
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 17, 2020 at 11:25:12AM -0700, Scott Branden wrote:
> From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
>=20
> Handle clk_get_rate() returning <=3D 0 condition to avoid
> possible division by zero.

You advertise handling <=3D 0, but in the code only =3D=3D 0 is checked. One
of the two is wrong ...

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--5ahgp5eqlhd5enic
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAl8SLnwACgkQwfwUeK3K
7AmfdwgAk8gWLxkwQKT9ApRiJ25C12PNu+T1nJQzle/itAdvq83W5gP6Lzud1iOh
a8px2Q5xIP20aHy5Z21OCUOzxqDl7+9o6kczLPLvJesanMC0+DCwBzkyQp/Vs/Kq
kSX+mdliVsMZGe0YVlXtuFtss1cs04KksXD0Ge1gMlciEXywgPMYhh0edJg53zKT
9jJ5NtV7tiNKacdSODSfdK6Z8KTTqzK36V+ZFWVzFZkJ9nk1XS7y1rbuC6unlK7O
2mPfE/QuKuP7tmslau5ejLlBZKoVS3qFeAFMzmaI/3HxMuML87XkMwz8ophU3TLl
sEZOpcLNEK2sPvO1T0WVo+PBtnEpuQ==
=6nzc
-----END PGP SIGNATURE-----

--5ahgp5eqlhd5enic--