Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbWEGMeI (ORCPT ); Sun, 7 May 2006 08:34:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932140AbWEGMeH (ORCPT ); Sun, 7 May 2006 08:34:07 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:262 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S932138AbWEGMeG (ORCPT ); Sun, 7 May 2006 08:34:06 -0400 Date: Sun, 7 May 2006 22:33:53 +1000 To: Andi Kleen Cc: Joachim Fritschi , davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [RFC][PATCH 2/2] Twofish cipher x86_64-asm optimized Message-ID: <20060507123353.GA4611@gondor.apana.org.au> References: <200605071157.03362.jfritschi@freenet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i From: Herbert Xu Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 997 Lines: 24 On Sun, May 07, 2006 at 12:38:30PM +0200, Andi Kleen wrote: > > It would be good if you could run some random input encrypt/decrypt tests > comparing the C reference version with yours. We have had bad luck > with assembler functions not quite implementing the same cipher > in the past. That's a very good point. The tcrypt module provides both correctness tests as well as speed tests for twofish. Please run it with your version versus the existing implementation. BTW, crypto stuff should cc linux-crypto@vger.kernel.org. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/