Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe
 failure
To:     David Miller <davem@davemloft.net>
CC:     <vishal@chelsio.com>, <kuba@kernel.org>, <jeff@garzik.org>,
        <divy@chelsio.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20200717062117.8941-1-wanghai38@huawei.com>
 <20200717.183913.1150846066923869608.davem@davemloft.net>
From:   "wanghai (M)" <wanghai38@huawei.com>
Message-ID: <23c0e185-5897-c6d0-1db7-b9ffa3df44ec@huawei.com>
Date:   Sat, 18 Jul 2020 15:57:13 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200717.183913.1150846066923869608.davem@davemloft.net>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


?? 2020/7/18 9:39, David Miller д??:
> From: Wang Hai <wanghai38@huawei.com>
> Date: Fri, 17 Jul 2020 14:21:17 +0800
>
>> The driver forgets to call destroy_workqueue when cxgb3 probe fails.
>> Add the missed calls to fix it.
>>
>> Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> You have to handle the case that the probing of one or more devices
> fails yet one or more others succeed.
>
> And you can't know in advance how this will play out.
>
> This is why the workqueue is unconditionally created, and only destroyed
> on module remove.
>
> .
Thanks for your explanation. I got it.