Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\))
Subject: Re: [PATCH 2/2] arm64: dts: meson: add support for the WeTek Core 2
From:   Christian Hewitt <christianshewitt@gmail.com>
In-Reply-To: <2ab5e28a-77f6-cac1-68ed-f0a23d5f2a24@baylibre.com>
Date:   Sat, 18 Jul 2020 13:07:02 +0400
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kevin Hilman <khilman@baylibre.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <109D2AE5-AF4B-4DAF-B2C5-3B8740BF33BD@gmail.com>
References: <20200718050056.1713-1-christianshewitt@gmail.com>
 <20200718050056.1713-2-christianshewitt@gmail.com>
 <2ab5e28a-77f6-cac1-68ed-f0a23d5f2a24@baylibre.com>
To:     Neil Armstrong <narmstrong@baylibre.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 18 Jul 2020, at 12:52 pm, Neil Armstrong <narmstrong@baylibre.com> =
wrote:
>=20
> Le 18/07/2020 =C3=A0 07:00, Christian Hewitt a =C3=A9crit :
>> The WeTek Core2 is a commercial device based on the Amlogic Q200 =
reference
>> design but with the following differences:
>>=20
>> - 3GB RAM, 32GB eMMC
>> - Blue and Red LEDs used to signal on/off status
>> - uart_AO can be accessed after opening the case; soldering required
>> - USB OTG is not accessible (inside the case)
>> - Realtek RTL8152 Ethernet (internal USB connection)
>>=20
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> arch/arm64/boot/dts/amlogic/Makefile          |  1 +
>> .../dts/amlogic/meson-gxm-wetek-core2.dts     | 90 =
+++++++++++++++++++
>> 2 files changed, 91 insertions(+)
>> create mode 100644 =
arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dts
>>=20
>> diff --git a/arch/arm64/boot/dts/amlogic/Makefile =
b/arch/arm64/boot/dts/amlogic/Makefile
>> index 5cac4d1d487d..4e2239ffcaa5 100644
>> --- a/arch/arm64/boot/dts/amlogic/Makefile
>> +++ b/arch/arm64/boot/dts/amlogic/Makefile
>> @@ -41,6 +41,7 @@ dtb-$(CONFIG_ARCH_MESON) +=3D meson-gxm-q201.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-gxm-rbox-pro.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-gxm-s912-libretech-pc.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-gxm-vega-s96.dtb
>> +dtb-$(CONFIG_ARCH_MESON) +=3D meson-gxm-wetek-core2.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-sm1-sei610.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-sm1-khadas-vim3l.dtb
>> dtb-$(CONFIG_ARCH_MESON) +=3D meson-sm1-odroid-c4.dtb
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dts =
b/arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dts
>> new file mode 100644
>> index 000000000000..44fc5ea38dc0
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dts
>> @@ -0,0 +1,90 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Copyright (c) 2020 Christian Hewitt <christianshewitt@gmail.com>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "meson-gxm.dtsi"
>> +#include "meson-gx-p23x-q20x.dtsi"
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +
>> +/ {
>> +	compatible =3D "wetek,core2", "amlogic,s912", =
"amlogic,meson-gxm";
>> +	model =3D "WeTek Core 2";
>> +
>> +	memory@0 {
>> +		device_type =3D "memory";
>> +		reg =3D <0x0 0x0 0x0 0x80000000>; /* 2 GiB or 3 GiB */
>> +	};
>> +
>> +	leds {
>> +		compatible =3D "gpio-leds";
>> +
>> +		blue {
>> +			color =3D <LED_COLOR_ID_BLUE>;
>> +			function =3D LED_FUNCTION_STATUS;
>> +			gpios =3D <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>;
>> +			default-state =3D "on";
>> +		};
>> +	};
>> +
>> +	adc-keys {
>> +		compatible =3D "adc-keys";
>> +		io-channels =3D <&saradc 0>;
>> +		io-channel-names =3D "buttons";
>> +		keyup-threshold-microvolt =3D <1710000>;
>> +
>> +		button-update {
>> +			label =3D "update";
>> +			linux,code =3D <KEY_VENDOR>;
>> +			press-threshold-microvolt =3D <10000>;
>> +		};
>> +	};
>> +
>> +	gpio-keys-polled {
>> +		compatible =3D "gpio-keys-polled";
>> +		#address-cells =3D <1>;
>> +		#size-cells =3D <0>;
>> +		poll-interval =3D <100>;
>> +
>> +		button-power {
>> +			label =3D "power";
>> +			linux,code =3D <KEY_POWER>;
>> +			gpios =3D <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
>> +		};
>> +	};
>> +};
>> +
>> +/* This is disabled as Realtek RTL8152 USB provides Ethernet */
>> +&ethmac {
>> +	status =3D "disabled";
>> +	phy-mode =3D "rmii";
>> +	phy-handle =3D <&internal_phy>;
>=20
> I think you can remove these 2 lines
>=20
>> +};
>> +
>> +&internal_phy {
>> +	pinctrl-0 =3D <&eth_link_led_pins>, <&eth_act_led_pins>;
>> +	pinctrl-names =3D "default";
>=20
> Simply add :
> status =3D "disabled";
>=20
>> +};
>> +
>> +&ir {
>> +	linux,rc-map-name =3D "rc-wetek-play2";
>> +};
>> +
>> +/* This is connected to the Bluetooth module: */
>> +&uart_A {
>> +	status =3D "okay";
>> +	pinctrl-0 =3D <&uart_a_pins>, <&uart_a_cts_rts_pins>;
>> +	pinctrl-names =3D "default";
>> +	uart-has-rtscts;
>> +
>> +	bluetooth {
>> +		compatible =3D "brcm,bcm43438-bt";
>> +		enable-gpios =3D <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
>> +		max-speed =3D <2000000>;
>> +		clocks =3D <&wifi32k>;
>> +		clock-names =3D "lpo";
>> +	};
>> +};
>>=20
>=20
>=20
> Otherwise looks good
>=20
> Neil

I=E2=80=99ve tested both changes, both are fine so will send v2.

Thanks for the quick review.

Christian