Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   B K Karthik <bkkarthik@pesu.pes.edu>
Date:   Sat, 18 Jul 2020 05:17:40 -0400
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] staging: rtl8188eu: include: enclosed macros in do-while
 loops
Message-ID: <20200718091740.mzinnyks5tjafowm@pesu-pes-edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7gh2egzqcljdzn7p"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--7gh2egzqcljdzn7p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

enclosed macros starting with if inside do-while loops to
avoid possible if-else logic defects

Signed-off-by: B K Karthik <karthik.bk2000@live.com>
---
 drivers/staging/rtl8188eu/include/odm_debug.h | 28 +++++++++++--------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/rtl8188eu/include/odm_debug.h b/drivers/stagin=
g/rtl8188eu/include/odm_debug.h
index 857c64b8d2f4..c7a928d396b0 100644
--- a/drivers/staging/rtl8188eu/include/odm_debug.h
+++ b/drivers/staging/rtl8188eu/include/odm_debug.h
@@ -76,20 +76,24 @@
 #endif
=20
 #define ODM_RT_TRACE(pDM_Odm, comp, level, fmt)				\
-	if (((comp) & pDM_Odm->DebugComponents) &&			\
-	    (level <=3D pDM_Odm->DebugLevel)) {				\
-		pr_info("[ODM-8188E] ");				\
-		RT_PRINTK fmt;						\
-	}
+	do {
+		if (((comp) & pDM_Odm->DebugComponents) &&			\
+			(level <=3D pDM_Odm->DebugLevel)) {			\
+			pr_info("[ODM-8188E] ");				\
+			RT_PRINTK fmt;						\
+		}
+	} while (0)
=20
 #define ODM_RT_ASSERT(pDM_Odm, expr, fmt)				\
-	if (!(expr)) {							\
-		pr_info("Assertion failed! %s at ......\n", #expr);	\
-		pr_info("      ......%s,%s,line=3D%d\n", __FILE__,	\
-			__func__, __LINE__);				\
-		RT_PRINTK fmt;						\
-		ASSERT(false);						\
-	}
+	do {
+		if (!(expr)) {							\
+			pr_info("Assertion failed! %s at ......\n", #expr);	\
+			pr_info("      ......%s,%s,line=3D%d\n", __FILE__,	\
+				__func__, __LINE__);				\
+			RT_PRINTK fmt;						\
+			ASSERT(false);						\
+		}
+	} while (0)
=20
 void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm);
=20
--=20
2.20.1


--7gh2egzqcljdzn7p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEEpIrzAt4LvWLJmKjp471Q5AHeZ2oFAl8SvjQACgkQ471Q5AHe
Z2qt7AwAqyyxs0GY+J+0HsnO0XAp6PNIVdb506/UI/umTX12rlVBwRSmmjPvB5O3
0LVTMxsp7N25Ds1KFPVr7mxttARjVTG8BusnYRGHhzk0u/56pGEWLxZqow5yVgfl
lxE6zFBwts467ho8YtbG5pMCZBsrH83bIBvwjXuXT7Ru8mlt2HuvcVxfD7QL9zLQ
Y/9cM62zrJWxYL+FAYdpiYe9Zcn6q+850l/uwuvY2hYce5Y329rSDes44MfDouI0
qe+n9gYmCFog8VTpDeRgWzWKddS90FfqbFrG/DPEV8VG043JvBbeq4Q9Whok7Eh7
eMP7ejNiV/XlFSHGBDn/cmWhAUfcvTVjlYY1En4FQKdLDopUbcYB8YclBgKEFWUd
3TEKsByunnAYeZKLHwJGc4hp/CdiTLarh/NZG7jTvSNkZLho9IlKc1ISZhQIg+6R
EYthXze0BtjTgYWR4xPrVboiRfPtmISA2+zEgFHvmlNRdNwV5VwAd+DC7oH4h677
kUKAqkpA
=Hygm
-----END PGP SIGNATURE-----

--7gh2egzqcljdzn7p--