Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp355704ybh; Sat, 18 Jul 2020 06:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHRhfRR/IayeiBxMK4su89KHcwSI3mpshO8yFYs5M47NUx4ZUxzi/aXrbH4d/LG+7BceeF X-Received: by 2002:a05:6402:203c:: with SMTP id ay28mr14033610edb.271.1595077931755; Sat, 18 Jul 2020 06:12:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595077931; cv=none; d=google.com; s=arc-20160816; b=v7MmyQ/XqjYpKwCZUvUJQOjDuPzq8Iz0Kf2Kl1013ukmqCxiaLIaVS/tJV+9gMYjwl OVmxnFp//Lt2olg/ZEzPbTPDQs+2HU2q8lcLO2U8laEdQ94LMhc/qF2Bhd5IzLzPj8X/ QaywGkld9grBWH+X3Yi/ZNKDg+eRC9LsR0Kca745EOCdIwAcZnACHwPYJnqkW8sD3/dz 0xVvh5szImuoU9iJ6ut8EWsv+Kt9ATrORMf7kmRazgUIlfFv2hFar7mRciPa8Tpn8oRK 2hRm8GVgawGnNr5EpDJhtfJlkpnmbyLyQ1YxsGo4fmzQzWDymn8BOInsgHyiGWrnqV4c RXLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:reply-to; bh=oC2TdJ/dNnzxfgvFOaYpP2+hh2Unvt7vg9RJcLPpBys=; b=pHtDMpLLkPNvH0V/9RufZAOTkRHg9eh0z228xzPoZuuvxaiAYH6U5qlMctuYNHwG/P ooME+RLJP09CYANi1RfVVNVsS2bsWRN97UlRxP3NEixRqypOVzdqfdjVjWPdNORxalqK yOA53sCtHkaRbAJnBRyHgRzYxufXthBAdgBvloFl4N8qHyP+aPj/IzRKEOFphQRW+6ND DpOwnAOgHqd1//5zK5IAtK6OAfcjZBWMefqZuI3OXQRqmusIv3gXGJ5424mAWkAUm7ZP sunB37WLAXK9BLDr/BaskqzCACPqGlDJm05XolqbHiQgwEvO0oz9vjzaXxQbFCxLRuPt paww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h20si7079477eje.434.2020.07.18.06.11.48; Sat, 18 Jul 2020 06:12:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbgGRNLZ (ORCPT + 99 others); Sat, 18 Jul 2020 09:11:25 -0400 Received: from mail-lj1-f175.google.com ([209.85.208.175]:40321 "EHLO mail-lj1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgGRNLY (ORCPT ); Sat, 18 Jul 2020 09:11:24 -0400 Received: by mail-lj1-f175.google.com with SMTP id j11so15653130ljo.7 for ; Sat, 18 Jul 2020 06:11:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oC2TdJ/dNnzxfgvFOaYpP2+hh2Unvt7vg9RJcLPpBys=; b=OfkYQBkMIQusx9j0wyKmnD3ro+ziao48G0ZSNq+m7PybQZHy9qc+uVsLoQ+BBu1Vhf S+E+7MdQjrn3lOvFmcoAaCq3MMY1Q5QrkRC621JAYQKMHQIBsN6neVDYhUMxU1t2ruiW 53Z6kuiVRgHFmewrb2fYl4FvZGgkeMOUpjhldAdImqtVgwzNPC+MyQIN2xP6B/uvYTtU u1l0YL5CkylyP29IEmUk2GsPmxQchgoliOVMDnpQHEtSYjmjZ/B/6vNOaHzoaKKBgyav 8ike5W5EWtZlw1gavhX2TViNDrClIixh9cI3uEBRBmFq8vsOY2A1eVVEB5tfhApZZfGS vK1g== X-Gm-Message-State: AOAM530OlngF8/jJbmkvjwsEs/hRiyekgcA1e+LT8F8VGhSH2DvNi2Rc QDG0lg66hlb9DLzThwqEqE8DPe0MrTU= X-Received: by 2002:a2e:a168:: with SMTP id u8mr5879183ljl.178.1595077881769; Sat, 18 Jul 2020 06:11:21 -0700 (PDT) Received: from [10.68.32.147] (broadband-37-110-38-130.ip.moscow.rt.ru. [37.110.38.130]) by smtp.gmail.com with ESMTPSA id w4sm2202676ljw.16.2020.07.18.06.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jul 2020 06:11:21 -0700 (PDT) Reply-To: efremov@linux.com Subject: Re: [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER To: Julia Lawall , Markus Elfring Cc: Coccinelle , linux-kernel@vger.kernel.org References: <0b9f2c58-e124-22d2-d91d-62a6e831c880@web.de> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Message-ID: Date: Sat, 18 Jul 2020 16:11:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/18/20 9:45 AM, Julia Lawall wrote: > This on is indeed a problem. I think it was not detected in testing, > because in the current kernel the rule never applies. But Denis, in > > - to = \(kmalloc\|kzalloc\) > (size,\(GFP_KERNEL\|GFP_USER\| > \(GFP_KERNEL\|GFP_USER\)|__GFP_NOWARN\)); > > you do indeed need to put - in front of the second and third lines as > well. Thanks, Markus, Julia. I will send v3. Julia, is it ok with you, if I will drop the last patch with "selfcheck" this time? Regards, Denis