Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 18 Jul 2020 15:24:39 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org,
        Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH 01/30] iio: adc: ad_sigma_delta: Remove unused variable
 'ret'
Message-ID: <20200718152439.32a48328@archlinux>
In-Reply-To: <20200716135928.1456727-2-lee.jones@linaro.org>
References: <20200716135928.1456727-1-lee.jones@linaro.org>
        <20200716135928.1456727-2-lee.jones@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 16 Jul 2020 14:58:59 +0100
Lee Jones <lee.jones@linaro.org> wrote:

> Fixes the following W=3D1 kernel build warning(s):
>=20
>  drivers/iio/adc/ad_sigma_delta.c: In function =E2=80=98ad_sd_trigger_han=
dler=E2=80=99:
>  drivers/iio/adc/ad_sigma_delta.c:405:6: warning: variable =E2=80=98ret=
=E2=80=99 set but not used [-Wunused-but-set-variable]
>  405 | int ret;
>  | ^~~
>=20
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Hi Lee,

My only thought on this one is perhaps we should put a warning in there
if ret isn't as expected.  Still never been one yet so I doubt anyone
minds too much.

Applied to the togreg branch of iio.git and pushed out as testing.
Note there is time for reviews from others before I push this out as
a non rebasing branch.  I'm also going to need to rebase it once
as previous pull hasn't quite gotten into staging/staging-next yet.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad_sigma_delta.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_=
delta.c
> index dd3d54b3bc8bb..f269b926440da 100644
> --- a/drivers/iio/adc/ad_sigma_delta.c
> +++ b/drivers/iio/adc/ad_sigma_delta.c
> @@ -402,7 +402,6 @@ static irqreturn_t ad_sd_trigger_handler(int irq, voi=
d *p)
>  	unsigned int reg_size;
>  	unsigned int data_reg;
>  	uint8_t data[16];
> -	int ret;
> =20
>  	memset(data, 0x00, 16);
> =20
> @@ -419,14 +418,12 @@ static irqreturn_t ad_sd_trigger_handler(int irq, v=
oid *p)
>  	case 4:
>  	case 2:
>  	case 1:
> -		ret =3D ad_sd_read_reg_raw(sigma_delta, data_reg, reg_size,
> -			&data[0]);
> +		ad_sd_read_reg_raw(sigma_delta, data_reg, reg_size, &data[0]);
>  		break;
>  	case 3:
>  		/* We store 24 bit samples in a 32 bit word. Keep the upper
>  		 * byte set to zero. */
> -		ret =3D ad_sd_read_reg_raw(sigma_delta, data_reg, reg_size,
> -			&data[1]);
> +		ad_sd_read_reg_raw(sigma_delta, data_reg, reg_size, &data[1]);
>  		break;
>  	}
> =20