Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] iio: trigger: Staticise stub functions
To:     Jonathan Cameron <jic23@kernel.org>,
        Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200714142456.67054-1-alexandru.ardelean@analog.com>
 <20200718172501.4ba58924@archlinux>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <017b33b1-b6f9-107b-b9c4-8c0abd0d6a3b@metafoo.de>
Date:   Sat, 18 Jul 2020 18:36:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200718172501.4ba58924@archlinux>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/18/20 6:25 PM, Jonathan Cameron wrote:
> On Tue, 14 Jul 2020 17:24:56 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
>> From: Lars-Peter Clausen <lars@metafoo.de>
>>
>> Make sure that the trigger function stubs are all static inline. Otherwise
>> we'll get linker errors due to multiple definitions of the same function.
>>
>> Fixes f8c6f4e9a40d4: ("iio: trigger: Staticise stub functions")
>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> I'm curious on what the actual build error is?  Static functions should
> result in independent implementations in each C file that includes
> them. Inline is normally considered a hint.  Hence what am I missing?

It's a bad commit message, my fault. This should have been

Make sure that the trigger function stubs are all static inline. 
Otherwise we might see compiler warnings about declared but unused 
functions.