Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 18 Jul 2020 22:53:30 +0530
From:   SAURAV GIREPUNJE <saurav.girepunje@gmail.com>
To:     Ian Abbott <abbotti@mev.co.uk>, gregkh@linuxfoundation.org
Cc:     hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] Staging: comedi: driver: Remove condition with no effect
Message-ID: <20200718172330.GA27103@saurav>
References: <20200712070628.GA18340@saurav>
 <20200713133438.GA3122574@kroah.com>
 <7653a794-d5ed-5d9f-95af-745a88769092@mev.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7653a794-d5ed-5d9f-95af-745a88769092@mev.co.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 13, 2020 at 02:41:19PM +0100, Ian Abbott wrote:
> On 13/07/2020 14:34, Greg KH wrote:
> > On Sun, Jul 12, 2020 at 12:36:28PM +0530, Saurav Girepunje wrote:
> > > Remove below warning in das1800.c
> > > WARNING: possible condition with no effect (if == else)
> > > 
> > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > ---
> > >   drivers/staging/comedi/drivers/das1800.c | 6 ------
> > >   1 file changed, 6 deletions(-)
> > > 
> > > diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c
> > > index f16aa7e9f4f3..7ab72e83d3d0 100644
> > > --- a/drivers/staging/comedi/drivers/das1800.c
> > > +++ b/drivers/staging/comedi/drivers/das1800.c
> > > @@ -1299,12 +1299,6 @@ static int das1800_attach(struct comedi_device *dev,
> > >   			outb(DAC(i), dev->iobase + DAS1800_SELECT);
> > >   			outw(0, dev->iobase + DAS1800_DAC);
> > >   		}
> > > -	} else if (board->id == DAS1800_ID_AO) {
> > > -		/*
> > > -		 * 'ao' boards have waveform analog outputs that are not
> > > -		 * currently supported.
> > > -		 */
> > > -		s->type		= COMEDI_SUBD_UNUSED;
> > 
> > What gave that warning?  The comment should show you why this is good to
> > keep as-is, right?
> 
> One option is to move the comment into the '} else {' part that follows this
> part.
> 
> -- 
> -=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
> -=( MEV Ltd. is a company registered in England & Wales. )=-
> -=( Registered number: 02862268.  Registered address:    )=-
> -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
@gregkh : Got the warning using coccinelle. 
@Ian: Yes, we can move comment to else part.