Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp633722ybh; Sat, 18 Jul 2020 15:45:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFnEC3Xv1tnGtjQcvYlE7+862t4Y6Hu4u1Ue5MwjNpMsALPr8gIqvXucwE3hFeoqdOtCFK X-Received: by 2002:a17:906:1403:: with SMTP id p3mr14071524ejc.106.1595112318952; Sat, 18 Jul 2020 15:45:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595112318; cv=none; d=google.com; s=arc-20160816; b=scsZPSIi66LXbgyuPwHVisRIlNuVenxhdoDLuQIYoQplolRJJ00VtfLrxDP7sjAaj6 hIbUeth8HEgXhNsm5XJIX1tuo6lR4cb2gOjQFyxqyGS88FX0bOUmgAE6ZFR9Psn5o9Ct 2vaWvtYcKwuUQq//2eEWxpJO0o9+sRQRHN5q3rBvZXCtzbWHQww4CUQYwzE+cMdfloSv iK1uudzXG1jjWmDlY75PhD6CWIpzkMyxm4stzHZJRILpIpyU1JzA3gh8zz8evsP7bUgy PWE5e96PuALMqakWsZvA07w95WDimFlGhHFHORDUzsC4rvQ2okANxHnR6+tkBzaUuSqo qH2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:ironport-sdr :ironport-sdr; bh=bTWWzNSiRQnZIMFedRWzzhIykguChAVIri5ra5euuSE=; b=FdEFPBSEaU/U48LEocJdomYnZgFSiHfR86SiNoJqHqLTJwerY4Ylg+3XJwBYRE9rJk hZD9JsPZCD6zS1bumsAs53fSBKTr1hUkw6m+KWAYyE3xovsAQ6MQPZpCx5/RShCtFj5/ tLB2CEj3OfxwVLWm/2+pbjrUk2kch4rVkPcE6Nabms8kfwDBWVTOJ1flgeQEQJ9tQy6H zm+gZwV3V343Wadl8U9hVOF1TyZHCU3g8GeK5m2nRBuYHzw6+xw8vQuc59ffDIq8Poop 4YKDRQO5jgqaZKrpdARK/QrTf/9CetXSR9uV6gUIcbNxQeDars2mT9JFcyUqABlttR5w k9uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si7660172eja.585.2020.07.18.15.44.08; Sat, 18 Jul 2020 15:45:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726284AbgGRWlX (ORCPT + 99 others); Sat, 18 Jul 2020 18:41:23 -0400 Received: from mga07.intel.com ([134.134.136.100]:19167 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726209AbgGRWlW (ORCPT ); Sat, 18 Jul 2020 18:41:22 -0400 IronPort-SDR: CnajUCU3tjqV4ooRvlOxzA/fSUVMT+/BmKrBE0WV8KuVcS1mvwPiQrBJSTW1lp3dcSYQLdCf6x 77apoKRVPNuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9686"; a="214466712" X-IronPort-AV: E=Sophos;i="5.75,368,1589266800"; d="scan'208";a="214466712" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2020 15:41:22 -0700 IronPort-SDR: 8Z20czbzkHF6PcKbBU6E26gGTv2MRTUA7rbSEBVFYwu/ZOVCemnJ6lulUX2UHhuo61+JlfykTv hmm9O4u3xQhA== X-IronPort-AV: E=Sophos;i="5.75,368,1589266800"; d="scan'208";a="461237003" Received: from jiewulu-mobl1.amr.corp.intel.com (HELO [10.255.0.53]) ([10.255.0.53]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2020 15:41:20 -0700 Subject: Re: Random shadow stack pointer corruption To: Yu-cheng Yu , Andy Lutomirski Cc: LKML , X86 ML , Borislav Petkov , Dave Hansen , "H.J. Lu" , Ingo Molnar , "Ravi V. Shankar" , Sebastian Andrzej Siewior , Tony Luck , Thomas Gleixner , Peter Zijlstra , Weijiang Yang References: <7653c6c74a4eee18b8bdc8262e0c0b5b95f9d771.camel@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Sat, 18 Jul 2020 15:41:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <7653c6c74a4eee18b8bdc8262e0c0b5b95f9d771.camel@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/20 11:24 AM, Yu-cheng Yu wrote: > On Sat, 2020-07-18 at 11:00 -0700, Andy Lutomirski wrote: >> On Sat, Jul 18, 2020 at 10:58 AM Yu-cheng Yu wrote: >>> Hi, >>> >>> My shadow stack tests start to have random shadow stack pointer corruption after >>> v5.7 (excluding). The symptom looks like some locking issue or the kernel is >>> confused about which CPU a task is on. In later tip/master, this can be >>> triggered by creating two tasks and each does continuous >>> pthread_create()/pthread_join(). If the kernel has max_cpus=1, the issue goes >>> away. I also checked XSAVES/XRSTORS, but this does not seem to be an issue >>> coming from there. >> >> What do you mean "shadow stack pointer corruption"? Is SSP itself >> corrupt while running in the kernel? Is one of the MSRs getting >> corrupted? Is the memory to which the shadow stack points getting >> corrupted? Is the CPU rejecting an attempt to change SSP? > > What I see is, a new thread after ret_from_fork() and iret back to ring-3, > its shadow stack pointer (MSR_IA32_PL3_SSP) is corrupted. Does corrupt mean random? Or is it a valid stack address, just not for _this_ thread? Or NULL? Or is it a kernel address? Have you tried tracing *ALL* the WRMSR's and XRSTOR's that write to the MSR?