Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp947764ybh; Sun, 19 Jul 2020 04:05:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4ih3JwKjEdNRfCRG4XzhlkCq7ywesNLWp9s9XhOtt1w6fznWOQ4QhEV3RzxRw3TAbkYqV X-Received: by 2002:a50:cd95:: with SMTP id p21mr1481712edi.12.1595156733023; Sun, 19 Jul 2020 04:05:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595156733; cv=none; d=google.com; s=arc-20160816; b=TvVfToz0ZvTnrPcrrHDGkOwZxLM7P338vhbfDo22azVcdpY6XTCK/RlKuZwTlLqIFA 7JR8S9mQTF2o75/KcmDpq+SUrj9s/gWHdLoy1fPPF8GiLDCkqr4WWCXzBhFtgnTgeWD2 cCfAsZQAZGxVggf6vH9mGIwVrpVMu6mt4koT6v9gnaiA0oMwzpjHibqSwwh9TIBEv94D +4z1D6eWBmLW1Uh1vXfb4QOMfQyEpRgmVHZwRl1TdkYIBIJ7FzoxIvG0wqUsF9W4kpRq IcSScRxZo31Qfg/WWXb1+sYwVuERSYAHzhpZNR18W2ENn80DXXtQwkC2t1b6skJKMeUk 1nEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=BCkd0SiB9GEZEm/3f2b30IUOcQr0ZUtjlrI2aEk3t+g=; b=rZ68rnCmKqqo5eRHd/CtWhPcAY1yODASGQ7y+0hf5qP7FhltcISp95nA5dDi+EvliU 0aoL9AmlxYehr/jz2ki7gDaBVeeHEYb0si8z7pWZal2CgPJCdx3IZiPHAAvFRGJKUVj/ NTmInXOJJxVGibdIDOTFV3Bc/bCi2l5RfniZeKwTyRyYG/7V7c2z2OMcBt0ppxSkNA8B Y36hs06e1HLGmpSLZogne0r0D/t5ZC+CV7XRriUTQzI9Nd8bhIG4KlmT5/D8732EveKc quVmRx1z9RyAd14ZWFwkAISVY0C3cBBwUugwW8Ii/30j7fVdG4Ma1kWaawk/czMImmyJ iTtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zsX/3lfs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lc19si7670288ejb.584.2020.07.19.04.05.08; Sun, 19 Jul 2020 04:05:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="zsX/3lfs"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726067AbgGSLE3 (ORCPT + 99 others); Sun, 19 Jul 2020 07:04:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:38730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgGSLE3 (ORCPT ); Sun, 19 Jul 2020 07:04:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D291C207DF; Sun, 19 Jul 2020 11:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595156668; bh=rUyPqN7o8n11Cuq/SsXI7IA/ehdlS6u9JPo8pQ6obYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zsX/3lfsy1Ub36Jau67UPnKyl3DBRtw/vDoLXbFs+/bIzT3vcaVvCxsyEs3k8/JC6 YQKw9FHPotTJoQdwx70r+lXlJoXnZziDrI498/XX9IfDGfpNM8NqsE4BlthPREqGZd mjpgNrLOCCnUXjkNTHstbrZKuSo0sI8uYz38FBjM= Date: Sun, 19 Jul 2020 13:04:39 +0200 From: Greg Kroah-Hartman To: B K Karthik Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Larry Finger Subject: Re: [PATCH 2/4] staging: rtl8188eu: include: fixed multiple parentheses coding style issues Message-ID: <20200719110439.GA266150@kroah.com> References: <20200718091626.uflhdcgkmhqij5b7@pesu-pes-edu> <20200719092652.GA257887@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 19, 2020 at 05:35:04AM -0400, B K Karthik wrote: > On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman > wrote: > > > > On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote: > > > fixed multiple parentheses coding style issues reported by checkpatch. > > > > > > Signed-off-by: B K Karthik > > > --- > > > drivers/staging/rtl8188eu/include/ieee80211.h | 4 +-- > > > .../staging/rtl8188eu/include/osdep_service.h | 4 +-- > > > drivers/staging/rtl8188eu/include/wifi.h | 34 +++++++++---------- > > > 3 files changed, 21 insertions(+), 21 deletions(-) > > > > You can never add warnings to the build, like this patch did. Always > > test-build your patches at the very least... > > understood, I will definitely do that. > but these warnings are (mostly) [-Wunused-value] and [-Wformat]. > that should not have (?) occurred due to the usage of parentheses. They are not there _before_ your patch, and only show up _after_ your patch, so perhaps your patch is wrong? :) thanks, greg k-h