Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1189958ybh; Sun, 19 Jul 2020 11:15:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz4cUH4Kf3WIE0imQrOvi9ba1l3DdAlX8eZXbzWS2cEmtvzSDR+xc8pVkeUn+581ArSiZI X-Received: by 2002:aa7:c609:: with SMTP id h9mr18731099edq.43.1595182558293; Sun, 19 Jul 2020 11:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595182558; cv=none; d=google.com; s=arc-20160816; b=QJ2vX3jiTsPf1zVE21aGWvbLWupTkeUc+yTgAiBF6bpXO9UZ2EDGiqI/I3IASF5a4o iGTKAgZ6eCOIfrs4wnrsyU+PyhAv4USNFxRBiHxLPJllPo7uDSlN47hm5zQlbs0WjLfH NuQmmzydlkALwd3WFu8hQVAktqZqGcXeWWAepceVnmMheMaZt6KbsayL1T+JMP6xLtxf YiSYc6cwZUo66PN+FHW6fTvFNWm4tPEPjweTjbVnzlf1oJfMI5RpKYYwVK/RlQ0Ti2Y0 MOewlBYbggwyCATVp0k2SWbClczNKrFeKiRfoZvY+jT2SF5QNaVc4Asfo786HjmKMQia /e7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=U0sBaS6HVqzpfKBpnUVcFnbevyq9tU/7y8PFM32HwN8=; b=ZqrxljO99f1CmlID/i8hlfZIWa6y7rxNhdlslSREMhryK3ywW+IK4+clnnejU7fhAT jaqvGWiK6063MqJxU8e2mMqKa8mjhYiesaHFPH8cgHeX6QIWwdNvFEqPpJbiLIRkFEjO qFp+XDl8+oEaVGtZuerbSLehV4QgzPzeMq1EAb+bINZy2RYXHJHcwALTPf+18usyvyvU ar98fnwxq7U4f1QIa6dnFIhNOd1UbZAAyzW35Y5kOwfXEkNtNFm58Z5DiirGF5Qit+7A /uivh82j1l+PHrrxxM5BISw8l3Or46UBO+qL+QQaJTGEhv1bgvVCYo+7NJiEEQyaX4kg ajSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e20si9363579edr.227.2020.07.19.11.15.35; Sun, 19 Jul 2020 11:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726963AbgGSSOU convert rfc822-to-8bit (ORCPT + 99 others); Sun, 19 Jul 2020 14:14:20 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:59907 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726714AbgGSSOT (ORCPT ); Sun, 19 Jul 2020 14:14:19 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-5klR_N-zOdqrqA9FpfFg-Q-1; Sun, 19 Jul 2020 14:14:12 -0400 X-MC-Unique: 5klR_N-zOdqrqA9FpfFg-Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9702C106B242; Sun, 19 Jul 2020 18:14:08 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE6A574F6C; Sun, 19 Jul 2020 18:14:05 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Ian Rogers , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian Subject: [PATCH 13/19] perf metric: Add cache_miss_cycles to metric parse test Date: Sun, 19 Jul 2020 20:13:14 +0200 Message-Id: <20200719181320.785305-14-jolsa@kernel.org> In-Reply-To: <20200719181320.785305-1-jolsa@kernel.org> References: <20200719181320.785305-1-jolsa@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding test that compute metric with other metrics in it. cache_miss_cycles = metric:dcache_miss_cpi + metric:icache_miss_cycles Acked-by: Ian Rogers Signed-off-by: Jiri Olsa --- tools/perf/tests/parse-metric.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c index 8c48251425e1..28f33893338b 100644 --- a/tools/perf/tests/parse-metric.c +++ b/tools/perf/tests/parse-metric.c @@ -11,6 +11,8 @@ #include "debug.h" #include "expr.h" #include "stat.h" +#include +#include static struct pmu_event pme_test[] = { { @@ -22,6 +24,18 @@ static struct pmu_event pme_test[] = { "( 1 + cpu_clk_unhalted.one_thread_active / cpu_clk_unhalted.ref_xclk ) )))", .metric_name = "Frontend_Bound_SMT", }, +{ + .metric_expr = "l1d\\-loads\\-misses / inst_retired.any", + .metric_name = "dcache_miss_cpi", +}, +{ + .metric_expr = "l1i\\-loads\\-misses / inst_retired.any", + .metric_name = "icache_miss_cycles", +}, +{ + .metric_expr = "(dcache_miss_cpi + icache_miss_cycles)", + .metric_name = "cache_miss_cycles", +}, }; static struct pmu_events_map map = { @@ -162,9 +176,28 @@ static int test_frontend(void) return 0; } +static int test_cache_miss_cycles(void) +{ + double ratio; + struct value vals[] = { + { .event = "l1d-loads-misses", .val = 300 }, + { .event = "l1i-loads-misses", .val = 200 }, + { .event = "inst_retired.any", .val = 400 }, + { 0 }, + }; + + TEST_ASSERT_VAL("failed to compute metric", + compute_metric("cache_miss_cycles", vals, &ratio) == 0); + + TEST_ASSERT_VAL("cache_miss_cycles failed, wrong ratio", + ratio == 1.25); + return 0; +} + int test__parse_metric(struct test *test __maybe_unused, int subtest __maybe_unused) { TEST_ASSERT_VAL("IPC failed", test_ipc() == 0); TEST_ASSERT_VAL("frontend failed", test_frontend() == 0); + TEST_ASSERT_VAL("cache_miss_cycles failed", test_cache_miss_cycles() == 0); return 0; } -- 2.25.4