Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1191087ybh; Sun, 19 Jul 2020 11:17:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzqw8JdZ5fq6AMXB1hyBQEdbdYx42j6HTKub9hmcEfrGCcrGKZqIvR0q/Ef1HLScfb6s9zT X-Received: by 2002:aa7:d285:: with SMTP id w5mr18958297edq.174.1595182673447; Sun, 19 Jul 2020 11:17:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595182673; cv=none; d=google.com; s=arc-20160816; b=SKSYHX/3Q0RvUMeBfk2ezb6DCqq6B1ehOX3AUaa2VIJ584j4t2OhBR41QLl3kHp+wB JiWz7c1fMjeMOygHgHajgwdTfi7VshxaSS8w6blsdK8iUP/EaHwvFIcLbdutg432QeVR bF+sKal8FU0KkyZOz+ryrCF0gR1idGTMNpmhHANw1sdt+fm/K0skggiRso49n3p98KNe 7BUhSHqJATY27wj6Aevqs8H4x5AJ5Egw8X/5a+idb+zMgdcw42UQtxXm/uuVRzK5MlLq /lY1HNQIbSLRKszrlrfLpu+qYkE07RHWSThjYJX0rFX2yncBwbu6c4jIW1B52II4egod QPGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=QXVbYyV7zeAvPsLPtBanPt71cVDLj1pJjlcZHyNSHZk=; b=SJMG6nVmbTuMhbzTUjPKOHB6InmT06hKIYAPgcrxeByuJ7NXkErvJZhkKD6UBrNgMC c7jf+I+PLMKx/jpAMReXCzibdoAkJMTokvTM/xaJp8/h3palXKjN2hm432vd7+k6Gj73 8I8JtJ3XURtMvhqXnJjDt4od02KByKPlwCmpk9yaMU3Tv2NyNw+Md4FdmvPOzFc+Ytnl yncNtP+V9ZiRrQuROSLNBAMw27p4tcyV6o+GccFmKVXmr9tuSVO8heJD1hB5e7+Q9PNr i81sfQswF5zCBIkozgZCgsVCE7e83Ig7p/ybpIKvzu1vAJhdDqV4MVcsMWSLu3NkisoQ bu5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be11si9124546edb.482.2020.07.19.11.17.30; Sun, 19 Jul 2020 11:17:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbgGSSOX convert rfc822-to-8bit (ORCPT + 99 others); Sun, 19 Jul 2020 14:14:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:55366 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726959AbgGSSOV (ORCPT ); Sun, 19 Jul 2020 14:14:21 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-Jcxo-tJxP86Y6eC5yBvJeQ-1; Sun, 19 Jul 2020 14:14:13 -0400 X-MC-Unique: Jcxo-tJxP86Y6eC5yBvJeQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C59C118A1DF0; Sun, 19 Jul 2020 18:14:11 +0000 (UTC) Received: from krava.redhat.com (unknown [10.40.192.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED583872E1; Sun, 19 Jul 2020 18:14:08 +0000 (UTC) From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Ian Rogers , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Michael Petlan , Andi Kleen , Kajol Jain , John Garry , "Paul A. Clarke" , Stephane Eranian Subject: [PATCH 14/19] perf metric: Add DCache_L2 to metric parse test Date: Sun, 19 Jul 2020 20:13:15 +0200 Message-Id: <20200719181320.785305-15-jolsa@kernel.org> In-Reply-To: <20200719181320.785305-1-jolsa@kernel.org> References: <20200719181320.785305-1-jolsa@kernel.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding test that compute DCache_L2 metrics with other related metrics in it. Acked-by: Ian Rogers Signed-off-by: Jiri Olsa --- tools/perf/tests/parse-metric.c | 71 +++++++++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/tools/perf/tests/parse-metric.c b/tools/perf/tests/parse-metric.c index 28f33893338b..aa4d5a9f09a8 100644 --- a/tools/perf/tests/parse-metric.c +++ b/tools/perf/tests/parse-metric.c @@ -36,6 +36,27 @@ static struct pmu_event pme_test[] = { .metric_expr = "(dcache_miss_cpi + icache_miss_cycles)", .metric_name = "cache_miss_cycles", }, +{ + .metric_expr = "l2_rqsts.demand_data_rd_hit + l2_rqsts.pf_hit + l2_rqsts.rfo_hit", + .metric_name = "DCache_L2_All_Hits", +}, +{ + .metric_expr = "max(l2_rqsts.all_demand_data_rd - l2_rqsts.demand_data_rd_hit, 0) + " + "l2_rqsts.pf_miss + l2_rqsts.rfo_miss", + .metric_name = "DCache_L2_All_Miss", +}, +{ + .metric_expr = "dcache_l2_all_hits + dcache_l2_all_miss", + .metric_name = "DCache_L2_All", +}, +{ + .metric_expr = "d_ratio(dcache_l2_all_hits, dcache_l2_all)", + .metric_name = "DCache_L2_Hits", +}, +{ + .metric_expr = "d_ratio(dcache_l2_all_miss, dcache_l2_all)", + .metric_name = "DCache_L2_Misses", +}, }; static struct pmu_events_map map = { @@ -194,10 +215,60 @@ static int test_cache_miss_cycles(void) return 0; } + +/* + * DCache_L2_All_Hits = l2_rqsts.demand_data_rd_hit + l2_rqsts.pf_hit + l2_rqsts.rfo_hi + * DCache_L2_All_Miss = max(l2_rqsts.all_demand_data_rd - l2_rqsts.demand_data_rd_hit, 0) + + * l2_rqsts.pf_miss + l2_rqsts.rfo_miss + * DCache_L2_All = dcache_l2_all_hits + dcache_l2_all_miss + * DCache_L2_Hits = d_ratio(dcache_l2_all_hits, dcache_l2_all) + * DCache_L2_Misses = d_ratio(dcache_l2_all_miss, dcache_l2_all) + * + * l2_rqsts.demand_data_rd_hit = 100 + * l2_rqsts.pf_hit = 200 + * l2_rqsts.rfo_hi = 300 + * l2_rqsts.all_demand_data_rd = 400 + * l2_rqsts.pf_miss = 500 + * l2_rqsts.rfo_miss = 600 + * + * DCache_L2_All_Hits = 600 + * DCache_L2_All_Miss = MAX(400 - 100, 0) + 500 + 600 = 1400 + * DCache_L2_All = 600 + 1400 = 2000 + * DCache_L2_Hits = 600 / 2000 = 0.3 + * DCache_L2_Misses = 1400 / 2000 = 0.7 + */ +static int test_dcache_l2(void) +{ + double ratio; + struct value vals[] = { + { .event = "l2_rqsts.demand_data_rd_hit", .val = 100 }, + { .event = "l2_rqsts.pf_hit", .val = 200 }, + { .event = "l2_rqsts.rfo_hit", .val = 300 }, + { .event = "l2_rqsts.all_demand_data_rd", .val = 400 }, + { .event = "l2_rqsts.pf_miss", .val = 500 }, + { .event = "l2_rqsts.rfo_miss", .val = 600 }, + { 0 }, + }; + + TEST_ASSERT_VAL("failed to compute metric", + compute_metric("DCache_L2_Hits", vals, &ratio) == 0); + + TEST_ASSERT_VAL("DCache_L2_Hits failed, wrong ratio", + ratio == 0.3); + + TEST_ASSERT_VAL("failed to compute metric", + compute_metric("DCache_L2_Misses", vals, &ratio) == 0); + + TEST_ASSERT_VAL("DCache_L2_Misses failed, wrong ratio", + ratio == 0.7); + return 0; +} + int test__parse_metric(struct test *test __maybe_unused, int subtest __maybe_unused) { TEST_ASSERT_VAL("IPC failed", test_ipc() == 0); TEST_ASSERT_VAL("frontend failed", test_frontend() == 0); TEST_ASSERT_VAL("cache_miss_cycles failed", test_cache_miss_cycles() == 0); + TEST_ASSERT_VAL("DCache_L2 failed", test_dcache_l2() == 0); return 0; } -- 2.25.4