Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1327250ybh; Sun, 19 Jul 2020 16:15:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzj4BnF86gxzEacmc0rLS+Yi/2f3vI4CS2NqYjgErGggeuFSCBIdwd95tudYQXqoytZ9TC X-Received: by 2002:a05:6402:706:: with SMTP id w6mr18623287edx.326.1595200544248; Sun, 19 Jul 2020 16:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595200544; cv=none; d=google.com; s=arc-20160816; b=hY74AlpUfPzBsCk584pwR1M9jBXKGeE3nnhSfM5v2O+WhaU//oRRh2s9G9ZH79moun q1h4EyetKLU3JRP3g165IUTSMCL6iZCa0SzHKpc5VFVYN307hbDJqHU77ldD7cYtiy9b V3OLIDEp79h8t2KqAgBbkbFloVkfsUWW3Wd5ONNnyYEIm56rIOw5jB7yx9WT1oRKX3M2 mqNdOMv6U9seIo6UFNTW3wScpofd4xwQ2cUyi3CzbL0feG576H75aVapJnLl0Ll/imHf JN9Bq+LVh8Xf3wFe3H9P8asrhTw24QUulU9voqUI3XyqP0QXzPBPZpLZEDaoGG8CauZc +d0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qjkiLR+60k9QfvgBZn9QHWt4cqJyvhTf2cZ66HgG/g8=; b=reY/pNDfPTTBdyWdwk53ZS7E7ffh+y2IB7iG847+mmBnaL7EMwq/lt3/eJp8kzSoqn Hzu7mtEy4KtjDDxR4iMmlEgSCfuB0FlWkQZ/4QUQ0UhVUEOKipzkKFf7I41Kd+KqBo6O 3KzDF4q2+WPDqhJ7Mt+byC47rbtYTc1fh2NKfgNA3ticAE68DkvPGwLh+7T2cGbpAyLb SgeMrMoI6gWQU4C7Ar6mJbrJ46lb+k5Z0P2PdrMcDT7f31KhMwSf4cjWHeYpm3VO7nyr YTGxMwNY2/4ydOchMKjbR+9hidVnmASC0xDKfzp9/Bl7eLl6dOBDZgFoQM5NFGx8VPYT dT/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sPRMmWyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z65si10312717ede.610.2020.07.19.16.15.22; Sun, 19 Jul 2020 16:15:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=sPRMmWyB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727853AbgGSXMO (ORCPT + 99 others); Sun, 19 Jul 2020 19:12:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726988AbgGSXLg (ORCPT ); Sun, 19 Jul 2020 19:11:36 -0400 Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38175C0619D4 for ; Sun, 19 Jul 2020 16:11:36 -0700 (PDT) Received: by mail-ot1-x341.google.com with SMTP id 18so10812706otv.6 for ; Sun, 19 Jul 2020 16:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qjkiLR+60k9QfvgBZn9QHWt4cqJyvhTf2cZ66HgG/g8=; b=sPRMmWyBOK0bzRCo5iKWMGlfVESewAW1LHC2FSlaxXboPedqHIeGGyXAOx9RHiMbyJ Dm4793memuW+pbTsUVs2nu9TpQ2d8qSRNCA5STBDZkeJ6dUXggT9BgAS9agHv+OjiRTG i8eFEfg1QI+o725zDmImsBTWvNYNevwtSxzdANnkPxwUc8OAjbt6dR+i+N6WaLiaj4Rq 9sgWWz0bjkI0h96XxMbkNRM7sXezeMqtdl7DcOrepbmO+lXrWG3ILtTISkp31zX7aA/+ hUZNMl4kxctT8ipL4c6ZzRBFKEk0xpTGGIMbp0D4S4Fg3CCyI0vLc67T2gCnKPrBbYut 6bBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qjkiLR+60k9QfvgBZn9QHWt4cqJyvhTf2cZ66HgG/g8=; b=UfpxEO2oomfqDlM5diqvMdWJAISx/+aIvQi1gaDxQe12oXOG24vIES4N5+cgNdHs/8 0HKPPfn1FfMdsbqIuZwfW/zJJAqMmiuoHLorNW9e0YT3kdvcQSq8nqfmeJZaNzczIwo7 nVVHjXUtCeGswtJ1fYMK4DkPOtppsyfObt1cVHNq1ikrpotP3ofgP6C1T7Rm9sfwiasH VRsnFE8D6JrUyV3wKhMWy7lJ8nwnMgwCDFuy35wdDQL+QtO+Myj3rTf3SBwBH+3H4DyX VldFyOw1mLLf9xMtOhsEBQuAA9Gg/Pb7kjkL2hK/d+S4pyD+Sps0/EBg5OzAq9JCKWyH ns/A== X-Gm-Message-State: AOAM5319UFPKGfQaYGz394Gy43uiZg+XrBm6nOmF4CM6wl2FGJnj7CC9 h49DNFtmwgoQeJPMebBoy60= X-Received: by 2002:a9d:7552:: with SMTP id b18mr17096570otl.344.1595200295572; Sun, 19 Jul 2020 16:11:35 -0700 (PDT) Received: from frodo.hsd1.co.comcast.net ([2601:284:8204:6ba0::5e16]) by smtp.googlemail.com with ESMTPSA id q19sm2394680ooi.14.2020.07.19.16.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2020 16:11:35 -0700 (PDT) From: Jim Cromie To: jbaron@akamai.com, linux-kernel@vger.kernel.org, akpm@linuxfoundation.org, gregkh@linuxfoundation.org Cc: linux@rasmusvillemoes.dk, Jim Cromie Subject: [PATCH v5 08/18] dyndbg: fix pr_err with empty string Date: Sun, 19 Jul 2020 17:10:48 -0600 Message-Id: <20200719231058.1586423-9-jim.cromie@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200719231058.1586423-1-jim.cromie@gmail.com> References: <20200719231058.1586423-1-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org this pr_err attempts to print the string after the OP, but the string has been parsed and chopped up, so looks empty. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 0cb5679f6c54..1d25a846553b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -420,7 +420,7 @@ static int ddebug_parse_flags(const char *str, unsigned int *flagsp, } } if (i < 0) { - pr_err("unknown flag '%c' in \"%s\"\n", *str, str); + pr_err("unknown flag '%c'\n", *str); return -EINVAL; } } -- 2.26.2