Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1392695ybh; Sun, 19 Jul 2020 18:39:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/lH1zGNZFvxJAfLsBWAxM/vBHYs3BxJpaJGcN4LZsJIIGK2zqVB32CNSgN0sDmxcbkMFt X-Received: by 2002:a17:906:b74e:: with SMTP id fx14mr18084866ejb.202.1595209141834; Sun, 19 Jul 2020 18:39:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595209141; cv=none; d=google.com; s=arc-20160816; b=v5bljWS2LLDl9EZpmvX6nTsJow93BzC7aG9nWCUzPmoLCboU3fJkURf5TN9pD6nUZP 6NaG+7aWod2C7CvnaQTh8mLGHO4L2Ie27rHGusJ136mNKfa/Buea0IXFs6X64uEPeVw/ n9Gom8qItdtgqtDatJNoWuZcJrZjU8jdXz8zXNVVB3F3SpWakKLK3ps8GrZt+AqbLFm/ 43SOf2uC1kR2Xw3v9v2Afmsf1EFuOaCJM74DB+4WGV08/rX/owHWkT9iV/jM+kEYn7AR hJ1H3w68w1mlCXY6LipwjHzxLeKGJJ3qexgsxdBeaWbQRxpfzA3i7jLHkQ2TwsackQER I4Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:to :from; bh=g7nTTHQV/skeA58zQD0XbQVHexf4g3dFAn2pA/5C690=; b=jhn+v0rsjUfGfdGXYPX1BREZZ2tcQ0U6XMR4hIKdgdYvishUHoXJdrDkPUZpi3z0sJ SidLjv/t1DUUqbwSxaJvIdMH9WIRAv6uXpeZRy9VUCKMilOxBuyeJ2++GEnG6CoIaAY/ 7hqJNHnxMEPR+37Cq/9bLwrYCjSbYJjBw4PztL3IHT/fWqeTl8u5aRii+shwT4bhk+gH G1UVjHaQJihjQKP+sOcH6otohQJyGjXQ1B5u2eBQt1nQJd0kWHgBRXybETXSLiabsVQ8 RzjDv7uhy4Lp+28NanbZYXV4+XN4J+PGXnfJB2fkhxCjSR12Z/F75200V0JCi8idSl+h Px7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si9753207ejo.44.2020.07.19.18.38.38; Sun, 19 Jul 2020 18:39:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726648AbgGTBiM (ORCPT + 99 others); Sun, 19 Jul 2020 21:38:12 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:46218 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726225AbgGTBiM (ORCPT ); Sun, 19 Jul 2020 21:38:12 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 850796397271D474BF22 for ; Mon, 20 Jul 2020 09:38:08 +0800 (CST) Received: from huawei.com (10.175.104.82) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Mon, 20 Jul 2020 09:38:05 +0800 From: Huang Guobin To: Subject: [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe Date: Sun, 19 Jul 2020 21:46:37 -0400 Message-ID: <20200720014637.12090-1-huangguobin4@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.104.82] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when of_reset_control_get_exclusive() failed. Add the missed call to fix it. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Reported-by: Hulk Robot Signed-off-by: Huang Guobin --- drivers/net/ethernet/atheros/ag71xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 112edbd30823..38cce66ef212 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag) ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio"); if (IS_ERR(ag->mdio_reset)) { netif_err(ag, probe, ndev, "Failed to get reset mdio.\n"); - return PTR_ERR(ag->mdio_reset); + err = PTR_ERR(ag->mdio_reset); + goto mdio_err_put_clk; } mii_bus->name = "ag71xx_mdio"; -- 2.17.1