Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] scsi: scsi_transport_sas: add missing newline when
 printing 'enable' by sysfs
To:     Bart Van Assche <bvanassche@acm.org>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>, <john.garry@huawei.com>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <guohanjun@huawei.com>
References: <1594975472-12486-1-git-send-email-wangxiongfeng2@huawei.com>
 <88b08a41-55b2-ae5d-fbe5-24439429855f@acm.org>
From:   Xiongfeng Wang <wangxiongfeng2@huawei.com>
Message-ID: <be74553e-24a1-5d2b-beb6-59cca1599450@huawei.com>
Date:   Mon, 20 Jul 2020 10:07:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <88b08a41-55b2-ae5d-fbe5-24439429855f@acm.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 2020/7/19 4:25, Bart Van Assche wrote:
> On 2020-07-17 01:44, Xiongfeng Wang wrote:
>> diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
>> index 182fd25..e443dee 100644
>> --- a/drivers/scsi/scsi_transport_sas.c
>> +++ b/drivers/scsi/scsi_transport_sas.c
>> @@ -563,7 +563,7 @@ static ssize_t do_sas_phy_enable(struct device *dev,
>>  {
>>  	struct sas_phy *phy = transport_class_to_phy(dev);
>>  
>> -	return snprintf(buf, 20, "%d", phy->enabled);
>> +	return snprintf(buf, 20, "%d\n", phy->enabled);
>>  }
> 
> For future sysfs show function patches, please use PAGE_SIZE as second
> snprintf() argument or use sprintf() instead of snprintf() because in
> this case it is clear that no output buffer overflow will happen. Using

Thanks for your advice. I will follow it in the future patches.

> any other size argument than PAGE_SIZE makes patches like the above
> harder to verify than necessary. Anyway:
> 
> Reviewed-by: Bart van Assche <bvanassche@acm.org>

Thanks,
Xiongfeng

>