Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   20 Jul 2020 14:13:35 +0900
Message-ID: <87o8oazs5a.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     <broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
        <robh+dt@kernel.org>, <lgirdwood@gmail.com>,
        <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
        <mkumard@nvidia.com>, <viswanathl@nvidia.com>,
        <rlokhande@nvidia.com>, <dramesh@nvidia.com>,
        <atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
        <swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH 03/10] ASoC: audio-graph: Support Codec with multiple endpoints
In-Reply-To: <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com>
References: <1595135417-16589-1-git-send-email-spujar@nvidia.com>
        <1595135417-16589-4-git-send-email-spujar@nvidia.com>
        <87365n2i2z.wl-kuninori.morimoto.gx@renesas.com>
        <870feaf2-3aa2-dbb8-f883-9b6cfcb36d82@nvidia.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Sameer

> >> diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c
> >> index 1e20562..b1903f9 100644
> >> --- a/sound/soc/generic/audio-graph-card.c
> >> +++ b/sound/soc/generic/audio-graph-card.c
> >> @@ -201,8 +201,7 @@ static void graph_parse_mclk_fs(struct device_node *top,
> >>   static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
> >>                                  struct device_node *cpu_ep,
> >>                                  struct device_node *codec_ep,
> >> -                               struct link_info *li,
> >> -                               int dup_codec)
> >> +                               struct link_info *li)
> > This patch breaks DPCM connection which is used for MIXer
> 
> Could you please elaborate a bit more as to what is broken with this?
> The problem I am trying to solve here is to have multiple endpoints
> for Codec port.

For example MIXer, it is like below.
If you removes "dup_codec", it breaks MIXer and/or TDM split mode.

	CPU0  ---+---- DAI
	         |
	CPU1  ---+

	cpu {
		ports {
			port@0 {
				cpu_0: endpoint {
					remote-endpoint = <&codec_0>;
				};
			};
			port@1 {
				cpu_1: endpoint {
					remote-endpoint = <&codec_1>;
				};
			};
		};
	};

	codec {
		port {
			codec_0: endpoint {
				remote-endpoint = <&cpu_0>;
			};
			codec_1: endpoint {
				remote-endpoint = <&cpu_1>;
			};
		}
	};

Thank you for your help !!

Best regards
---
Kuninori Morimoto