Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: dtMT/GYKR2F/RvGS/GvaTaC9Rlgl9C1tV0iVshfCmR0b4ZErGPMvd8JgrPDiEYKKfTHGN0oYrR
 d08AxqErckiw==
References: <20200720025309.18597-1-wanghai38@huawei.com> <f31ec3e646c9ba73c09f821a173c20110346deab.camel@perches.com>
User-agent: mu4e 1.4.10; emacs 26.3
From:   Shay Agroskin <shayagr@amazon.com>
To:     Joe Perches <joe@perches.com>
CC:     Wang Hai <wanghai38@huawei.com>, <gtzalik@amazon.com>,
        <saeedb@amazon.com>, <zorik@amazon.com>, <davem@davemloft.net>,
        <kuba@kernel.org>, <sameehj@amazon.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range
In-Reply-To: <f31ec3e646c9ba73c09f821a173c20110346deab.camel@perches.com>
Date:   Mon, 20 Jul 2020 09:38:26 +0300
Message-ID: <pj41zllfjebsil.fsf@ua97a68a4e7db56.ant.amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Joe Perches <joe@perches.com> writes:

> On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote:
>> Fix sparse build warning:
>> 
>> drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning:
>>  Using plain integer as NULL pointer
> []
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
>> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> []
>> @@ -2190,11 +2190,10 @@ static void 
>> ena_del_napi_in_range(struct ena_adapter *adapter,
>>  static void ena_init_napi_in_range(struct ena_adapter 
>>  *adapter,
>>  				   int first_index, int count)
>>  {
>> -	struct ena_napi *napi = {0};
>>  	int i;
>>  
>>  	for (i = first_index; i < first_index + count; i++) {
>> -		napi = &adapter->ena_napi[i];
>> +		struct ena_napi *napi = &adapter->ena_napi[i];
>>  
>>  		netif_napi_add(adapter->netdev,
>>  			       &adapter->ena_napi[i].napi,
>
> Another possible change is to this statement:
>
>  		netif_napi_add(adapter->netdev,
> 			       &napi->napi,
> 			       etc...);

Yup, missed that myself. Wang, if you don't mind please apply 
Joe's change as well.

Thanks, Shay