Date: Mon, 8 May 2006 09:16:33 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>, Nick Piggin <nickpiggin@yahoo.com.au>,
       Zwane Mwaikambo <zwane@linuxpower.ca>,
       Srivatsa Vaddagiri <vatsa@in.ibm.com>, Ashok Raj <ashok.raj@intel.com>,
       Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 3/10] explict migrate tasks for cpu removal
Message-ID: <20060508071633.GA10309@elte.hu>
References: <1147067143.2760.81.camel@sli10-desk.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1147067143.2760.81.camel@sli10-desk.sh.intel.com>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 922
Lines: 28


* Shaohua Li <shaohua.li@intel.com> wrote:

> Make cpu_down explictly migrate tasks off dead cpus, this is to fix a 
> dead lock in bulk cpu hotremoval (An example of the deadlock is one 
> dead cpu is notifing udev the cpu is dead and khelper thread is on 
> another dead cpu). Detail info is in the code.

looks good, except some style issues:

> +	/* No need to migrate the tasks: it was best-effort if
> +	 * they didn't do lock_cpu_hotplug().  Just wake up
> +	 * the requestors. */

needs proper comment style.

> +		migration_req_t *req;
> +		req = list_entry(rq->migration_queue.next,
> +				 migration_req_t, list);

missing newline between variables and code.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/