Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Jul 2020 10:06:01 +0200
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Willy Wolff <willy.mh.wolff.ml@gmail.com>,
        Marian Mihailescu <mihailescu2m@gmail.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos: Disable frequency scaling for FSYS bus
Message-ID: <20200720080601.GA3845@kozik-lap>
References: <CGME20200714064824eucas1p2ea0d2ee2c109c351fe489050905b4104@eucas1p2.samsung.com>
 <20200714064759.31772-1-m.szyprowski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200714064759.31772-1-m.szyprowski@samsung.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 14, 2020 at 08:47:59AM +0200, Marek Szyprowski wrote:
> Commit 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
> values correct for Exynos5422 Odroids") changed the parameters of the
> OPPs for the FSYS bus. Besides the frequency adjustments, it also removed
> the 'shared-opp' property from the OPP table used for FSYS_APB and FSYS
> busses.
> 
> This revealed that in fact the FSYS bus frequency scaling never worked.
> When one OPP table is marked as 'opp-shared', only the first bus which
> selects the OPP sets the rate of its clock. Then OPP core assumes that
> the other busses have been changed to that OPP and no change to their
> clock rates are needed. Thus when FSYS_APB bus, which was registered
> first, set the rate for its clock, the OPP core did not change the FSYS
> bus clock later.
> 
> The mentioned commit removed that behavior, what introduced a regression
> on some OdroidXU3 boards. Frequency scaling of the FSYS bus causes
> instability of the USB host operation, what can be observed as network
> hangs. To restore old behavior, simply disable frequency scaling for the
> FSYS bus.
> 
> Reported-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
> Fixes: 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the values correct for Exynos5422 Odroids")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 6 ------
>  1 file changed, 6 deletions(-)

Thanks Willy and Marek for digging into this, applied.

A follow up question would be if other boards (Exynos4412) require the
same?

Best regards,
Krzysztof