Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1560867ybh; Mon, 20 Jul 2020 01:07:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZAEqEi8ywzA0+Rg2Fbe1EPmdMPTKt50ldKuVPHi1T4rhkWn2n1AfZqlxvzQOnL/gnz1NZ X-Received: by 2002:aa7:da8a:: with SMTP id q10mr20540266eds.139.1595232441523; Mon, 20 Jul 2020 01:07:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595232441; cv=none; d=google.com; s=arc-20160816; b=Bir+0mwCSMlANHq18wNEdhO0vKwgLq1iVEdx+492X5oyOFk3TfdzCqGmeHmFZDWW/7 one7VXikWtngc40U8XSDHhoUV8Z5Ihog8AZ1+3El4ksIMYnbqyFq1jrkh5I7XLZ3T6aD lhIBGqKqLHvUdU4UhJHU2j7bTyahL2+veMBQQ16naF7iCJZV3Qt5jJIDqE8UTsiNYXFC Znwl4nOP9OVxboIIYC4tYEPk7ZW+WXXK1nAKRaBG7OMgW1XCgl4/8zDdgKAEInekZWjC iePT5xj00EqLjht3VwTap8P4n9LhRDCrGmEDZ9NdpLmtCi/wLAmv02VAHRWISRs58g1i oUIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=BtSNWKnb2qQ5IcZVsHnQ+Mm/WK7aCSDiChMesk4hrns=; b=hRwR35Uy/5gl9cC6OSHH6sWyJkyavNXeOBokwJAcUKnKD6D9avXQaUPTKg6kVuVy+Y Jlu4HNA8hrqsWHqTWY4uAcouFoFVxpfZZnBwWOL6ijx0oKxBvSrhV2LUkPSs32LkHIdk TDNrsY2FMfM4fbfrT0AFwx1yh6fgqbutamHZz2YnWgXQjne/ewQZt1Ij+vJGKR6wxfX1 fwdxVnuwvH98U0Z8ST9ibJ2GfBXxsKFvoXjQ7k0Bi8wHYkUgv8WXjn0TMcic8v0MW0bf xPGbcXYpn0Y0jPP/XXUg3hiM/zlmzIZHO41TT54XAGrry+bUAmN4zIdTwn7fuGPVTEPy 5g+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si9990889ejx.722.2020.07.20.01.06.58; Mon, 20 Jul 2020 01:07:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbgGTIGS (ORCPT + 99 others); Mon, 20 Jul 2020 04:06:18 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:45206 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725815AbgGTIGS (ORCPT ); Mon, 20 Jul 2020 04:06:18 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id B8920FD77153135EF878; Mon, 20 Jul 2020 16:06:16 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Mon, 20 Jul 2020 16:06:07 +0800 From: Jing Xiangfeng To: , , , CC: , , Subject: [PATCH] ipmi: remve duplicate code in __ipmi_bmc_register() Date: Mon, 20 Jul 2020 16:08:38 +0800 Message-ID: <20200720080838.148737-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an error path. So we can remove duplicate code in the if (rv). Signed-off-by: Jing Xiangfeng --- drivers/char/ipmi/ipmi_msghandler.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index e1b22fe0916c..737c0b6b24ea 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3080,8 +3080,6 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, rv = sysfs_create_link(&bmc->pdev.dev.kobj, &intf->si_dev->kobj, intf->my_dev_name); if (rv) { - kfree(intf->my_dev_name); - intf->my_dev_name = NULL; dev_err(intf->si_dev, "Unable to create symlink to bmc: %d\n", rv); goto out_free_my_dev_name; -- 2.17.1