Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1567287ybh; Mon, 20 Jul 2020 01:20:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjKg4ZUZwt3IfSyY/Ss0Ukrd93LkJFzmtDVc+GGHf4ecRyzp9/saQma0PX3S4NGt1AL1zo X-Received: by 2002:a17:906:b0d:: with SMTP id u13mr19200328ejg.342.1595233212618; Mon, 20 Jul 2020 01:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595233212; cv=none; d=google.com; s=arc-20160816; b=Z3Ki71C49rVV1fYlkCaHawo5AHr2sIUsX0ySmBuEboSXAcGamTR+VInsO6PYjdw66O uOtHzTMsUGv4BvlVkJ7tTVJi//FeFVsTJf1dJinXb7RBvcmsYEAp2KgtYc3fMS8DeIsz GyPwAEyDapTGI/seej+fss9ZajKNiHYfPu2598SDeNtwIaEhkkKFo3PwbVwbmUAJeZVK N6Wkq5Mwo7oP6uV3pplJTmH79ahaufOoFmoQ2OdLTjq2Xv1PWjfyeeJEaguogTor2uap Y0A+sLtgcc4E3ASzrf70dIKU8HcdOEYZWzyf3KhJjqmvc0RUOt5houkD5LtzOJfZH3c0 xZ+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=vV2pFHU/EDJl7TQaIzn5w4psMWaf6YO4PWF7gnK4n3k=; b=rhaRN+Z5bMRotznvdzxKTe6M2gaCq5Y7OlKIQcvc5elQornOxszsDyi4U6Dvp+YzAS dRcVDvR5FiyOoOwMhu504apk1/DYy2IL6sUdget7gpaQJFDssd91aemieGblg8uQQAUM LKm1TxtxI/4gUxD1TMC0+aQzWsCqH0sYnc3svSGPQjY2gGkuiVMbTl0DGeVBGwB1yCsh jpdiQP6baF+fXuWw6b9IFvrovveTzGepbcz/NoFnSBhk8dzgbqXYljx1GlVbEAZTUgCo gOF1tTNxlqTodOOIoe7RU4PnGGmPZ9lp84YQ7QAQJha6dFBc5R38UkOpzY57MmfCetYu 73FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="YF/LJ8/P"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g25si10515570eds.190.2020.07.20.01.19.49; Mon, 20 Jul 2020 01:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="YF/LJ8/P"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbgGTITS (ORCPT + 99 others); Mon, 20 Jul 2020 04:19:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:44652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbgGTITR (ORCPT ); Mon, 20 Jul 2020 04:19:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E68982080D; Mon, 20 Jul 2020 08:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595233157; bh=EtZ9AhynlGhfBWyIDxGxkbdjeCY/mrbQUUjyIFA87HU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YF/LJ8/PYqVCNTC9nEdwYHwGsSUGCAP4XblC812s9WO/qGz1FiiKuS+7eZH/otrQl bc6nKiY2dclZvhOBBhCZC1flVILlCb9+wSdcCDGGygq/naFoerYbvwKGSBRJQuaXvF qfuQh8WgbOH2boGqzcoGoj1gy0uvs1YAkJIx5KpU= Date: Mon, 20 Jul 2020 10:19:27 +0200 From: Greg Kroah-Hartman To: Ian Abbott Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] staging: comedi: INSN_CONFIG_DIGITAL_TRIG fixes Message-ID: <20200720081927.GA688558@kroah.com> References: <20200717145257.112660-1-abbotti@mev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200717145257.112660-1-abbotti@mev.co.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 17, 2020 at 03:52:53PM +0100, Ian Abbott wrote: > These patches correct problems with INSN_CONFIG_DIGITAL_TRIG comedi > configuration instructions in various comedi drivers, in particular the > use of unconstrained bit shift amounts from userspace leading to > undefined behaviour (although hopefully not the kernel crashy sort). > > The patches have been marked for inclusion in the stable tree. Note > that patch 4 changes a similar area of code to Dan Carpenter's commit > ef75e14a6c93 ("staging: comedi: verify array index is correct before > using it"), so I have indicated it as a prerequisite. > > *Note to Greg KH*: I have based these patches on your "staging-linus" > branch due to the prerequisite ef75e14a6c93 mentioned above being > present in neither "staging-next" nor "staging-testing" at the time of > posting. Thanks for the note, all now queued up to the proper branch. greg k-h