Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1579433ybh; Mon, 20 Jul 2020 01:47:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC1DYn5XjR7ksxk3zrsDK7TcYYVsMKbk3NQ46INgV6UKo8GyKEWfUduwtsEze90SLs8Ufw X-Received: by 2002:a50:c88d:: with SMTP id d13mr20899741edh.104.1595234826898; Mon, 20 Jul 2020 01:47:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595234826; cv=none; d=google.com; s=arc-20160816; b=pbhUj3QORYPEUwyWGaorzaOHjSb0G6Kl/7R3O4ibVe1Unb7CRS7AFKmnGO4/Sm8U3f 9Oia2wIJ8GijGyrE3IqM0KNZmY1OH56mSE3SnUbvqdHrUra+KBallEqbTaZepjIPsKEU A0D9BEE97BM2P8zKUYcLkHWvUZqQlO2dMBY3ln9RWA7QMnAOOUHo3q9fH0S9ZfVVLSGo rF/aFzqLC7nsizRHxwCTKCUAm6pmSEBMoudwi8Q3BSNay/c6yqVyDc7lUQJAOisqsZ7I ETdvlOq4qQx66e58ohigbt2pNutlVjqKFmRu9kwLl5f+izQh7StSLx8CL3TsDigu1Ji5 ZCow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=Y4ds3JdbIkXvX07758cWefiMlGH9N73+CMEO/QUOxtUF7M5oG7swT6Hv318wl+qXnx 3eOWyUkmVbMI/1PPk9+DBxv1Fd5WsEFrecgf3eJKDz/rrXeMz/zMDBh+2nlGeShGvp0I /9P9hGhFgIoH7IiILru0OF47pfr48SAXGNmrrXGb+/ZhkdzqB9+etfGTlW0Ddv7fu0LW NFiKH8omNoley3VfEbVdCYKGVPOhVOKewJ1YCv9HAX4ADxhx1aKhs64ySsG5q29DyTw0 HJ1jo83bZ9Q8XyXO17JNcwBYEG9bxIUQ1kOo9tTbpL3d8EkG3IObRtkDEh0b/4zpLJvH 4DBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=e6djTCYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si9902827eja.585.2020.07.20.01.46.44; Mon, 20 Jul 2020 01:47:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=e6djTCYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727062AbgGTIny (ORCPT + 99 others); Mon, 20 Jul 2020 04:43:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbgGTIny (ORCPT ); Mon, 20 Jul 2020 04:43:54 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7D94C061794 for ; Mon, 20 Jul 2020 01:43:53 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id f5so19314260ljj.10 for ; Mon, 20 Jul 2020 01:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=e6djTCYWEj2Fmi95lUFWKgkZcJHCyeTSf7Syl643UoYLetz7sglV0iZEAzz9bdhAWy AV2kduveWFWI+JWAlK2oNtidKKo/CEuAaKD0MJ5Pp2tRK5UEZOnqUQB+URJ8qpBiS3E0 7BLXT/fa/imiZu0Qgtj10PZL/JBmO+Pz1dtSqFtftbPH5ryJlZX1B4ohWJEXiBEEvDCm QXR5JmQwVkqYm8SkgaPhzlXf0D9fpQhWmfdlnKXyWsNJSVXFpVk2mp2087rkuizdb6pR gp9yJayr7YSyuNloyVlOeoyOmDejlgs1239X59/cPzNKO7ss8eXDNgChuv/x7qWhxATI 9lQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ktede3490cF8xrICApRVvg9tnZvpytnPociFCS3lvDc=; b=CMHRftXflLOZh5dK2SxGbPhDS9ng+zvGXqGrDnI8Ujwjn9XUVU1zzFPmnVA4P9RBzq y6JBs6GJY5ykj6vDj0IjwpdpukBqPSEqQtUglVSwPajCu52gsQbiY2iF1p5Tzgc7fNSe VzrSDh+nqSwBygA1bcpsF8edVasJfzzx14FfQEwliCqIo3/j8ofws9PtSwrgP8x2xWv1 Yhmr2H7nLiOTEbWz6clKJre3pqn0R2k49CNXMUZqtW8xrARK7UOReGkixHuWyPNcRsYt ULpH4oPmBP1UABVUR4wylZ6iQ9EB9b8sV89jiWStPbld3ZqldDGusQI7eAKAIGDSznjM noPQ== X-Gm-Message-State: AOAM533Mq7MIrPORP/nexjmGqMWYUXXBrlrLc3LwtsUkGl418XLX9s98 8BSPZJlAnYEhF/sk/RQQXD1pZg== X-Received: by 2002:a05:651c:1057:: with SMTP id x23mr9133434ljm.116.1595234632369; Mon, 20 Jul 2020 01:43:52 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id s62sm3101085lja.100.2020.07.20.01.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 01:43:51 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E7866102393; Mon, 20 Jul 2020 11:43:51 +0300 (+03) Date: Mon, 20 Jul 2020 11:43:51 +0300 From: "Kirill A. Shutemov" To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com Subject: Re: [PATCH v16 06/22] mm/thp: clean up lru_add_page_tail Message-ID: <20200720084351.v3skr3pluudy6fer@box> References: <1594429136-20002-1-git-send-email-alex.shi@linux.alibaba.com> <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1594429136-20002-7-git-send-email-alex.shi@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2020 at 08:58:40AM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov