Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <cover.1594708863.git.frank@allwinnertech.com> <b8761e036b25f20873534e5f8d10b37b5d2ce72c.1594708864.git.frank@allwinnertech.com>
 <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org> <CAEExFWv9_1kec_b+t+nnvT3cziXzmVa8GzJT3pQAZiCf4KA0ig@mail.gmail.com>
 <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org>
In-Reply-To: <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org>
From:   Frank Lee <tiny.windzz@gmail.com>
Date:   Mon, 20 Jul 2020 17:27:29 +0800
Message-ID: <CAEExFWsJBizFArd+9Mh6D=o6rvD7GLPZ-1pNFzTvBiE+uKwVhQ@mail.gmail.com>
Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for
 calibration data in sun50i_h6_ths_calibrate
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Frank Lee <frank@allwinnertech.com>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Amit Kucheria <amit.kucheria@verdurent.com>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?6buE54OB55Sf?= <huangshuosheng@allwinnertech.com>,
        liyong@allwinnertech.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

HI,
On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 17/07/2020 09:35, Frank Lee wrote:
> > On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano
> > <daniel.lezcano@linaro.org> wrote:
> >>
> >> On 14/07/2020 09:13, Frank Lee wrote:
> >>> From: Yangtao Li <frank@allwinnertech.com>
> >>>
> >>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of
> >>> calculation. On the other hand, the newer SOC may store other data in
> >>> the space other than 12bit sensor data. Add mask operation to read data
> >>> to avoid conversion error.
> >>>
> >>> Signed-off-by: Yangtao Li <frank@allwinnertech.com>
> >>> Reviewed-by: Yangtao Li <tiny.windzz@gmail.com>
> >>
> >> Can you clarify these SoB ?
> >
> > Previously I used 'Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>',
> > maybe this should be removed directly?
> >
> >>
> >> Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ?
> >>
> >
> > Yeah.
>
> You are not supposed to add reviewed-by yourself. Please remove it.

Should I resend the entire series or just the thermal patch?
What about those that have been applied.

Thx,
Yangtao