Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200720094449.32282-1-wens@kernel.org>
In-Reply-To: <20200720094449.32282-1-wens@kernel.org>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Mon, 20 Jul 2020 17:54:04 +0800
Message-ID: <CAGb2v65RDqrHxGPOkrNvjd2v8=bLmBaK61rvQ-dN1bbvSs1MQg@mail.gmail.com>
Subject: Re: [PATCH] reuglator: gpio: Honor regulator-boot-on property
To:     Chen-Yu Tsai <wens@kernel.org>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Maxime Ripard <mripard@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Please ignore this one. I'll send v2 shortly.

On Mon, Jul 20, 2020 at 5:44 PM Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> When requesting the enable GPIO, the driver tries to do so with the
> correct output level matching the current state. This is done by
> checking the boot_on constraint, which is derived from the
> regulator-boot-on property in the device tree. This is especially
> important if the regulator is a critical one, such as a supply for
> the boot CPU.
>
> Honor the regulator-boot-on property by checking the boot_on
> constraint setting. This is the same as what is done in the fixed
> regulator driver.
>
> Also drop support for the undocumented enable-at-boot property. This
> property was not documented in the original commit introducing DT
> support, nor is it now, and there are no in-tree device trees that use
> this property.

I'll rework the commit log so it makes more sense. (and fix the typo ...)

ChenYu

> Fixes: 006694d099e8 ("regulator: gpio-regulator: Allow use of GPIO controlled regulators though DT")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/regulator/gpio-regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
> index 110ee6fe76c4..5646b7a26288 100644
> --- a/drivers/regulator/gpio-regulator.c
> +++ b/drivers/regulator/gpio-regulator.c
> @@ -148,7 +148,7 @@ of_get_gpio_regulator_config(struct device *dev, struct device_node *np,
>
>         config->supply_name = config->init_data->constraints.name;
>
> -       if (of_property_read_bool(np, "enable-at-boot"))
> +       if (config->init_data->constraints.boot_on)
>                 config->enabled_at_boot = true;
>
>         of_property_read_u32(np, "startup-delay-us", &config->startup_delay);
> --
> 2.27.0
>