Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Jul 2020 06:32:30 -0500
From:   Corey Minyard <cminyard@mvista.com>
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc:     minyard@acm.org, arnd@arndb.de, gregkh@linuxfoundation.org,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: remve duplicate code in __ipmi_bmc_register()
Message-ID: <20200720113230.GA2961@minyard.net>
Reply-To: cminyard@mvista.com
References: <20200720080838.148737-1-jingxiangfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200720080838.148737-1-jingxiangfeng@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 20, 2020 at 04:08:38PM +0800, Jing Xiangfeng wrote:
> __ipmi_bmc_register() jumps to the label 'out_free_my_dev_name' in an
> error path. So we can remove duplicate code in the if (rv).

Looks correct, queued for next release.

Thanks,

-corey

> 
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index e1b22fe0916c..737c0b6b24ea 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -3080,8 +3080,6 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf,
>  	rv = sysfs_create_link(&bmc->pdev.dev.kobj, &intf->si_dev->kobj,
>  			       intf->my_dev_name);
>  	if (rv) {
> -		kfree(intf->my_dev_name);
> -		intf->my_dev_name = NULL;
>  		dev_err(intf->si_dev, "Unable to create symlink to bmc: %d\n",
>  			rv);
>  		goto out_free_my_dev_name;
> -- 
> 2.17.1
>