Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1690170ybh; Mon, 20 Jul 2020 05:00:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzT2jq6bWtdyb4GSVy+beJxCxdZXUdpd3fmjX1WupYpitg5jqcVzU+WJvIIDjhmXXVCPFl5 X-Received: by 2002:a17:906:fcb1:: with SMTP id qw17mr20010243ejb.445.1595246405232; Mon, 20 Jul 2020 05:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595246405; cv=none; d=google.com; s=arc-20160816; b=SLr5cS4PUVI/f1IhywytY/fYkwf3c1QtQ83MgHzt4xcvXRD0zWf3J3O+yYQo4YjJm7 dtO1H/rvX8MoY5YTclGTtGpZm6RQqGGBGEOayu5G74uWefArk8kTVwxiFaxccGokOIZF uWbjBsfvTdAywdbJ658NG6vNJQdTP6Zo3NyeTA+iZY221xAwzGDFYYrzUQUFhJDOmpCm teFYit9I8pDjuQR8xnQcuIagi1PwbOdsP1iPdx/y4Z78pVreSrPZFyHfpLoJDAsn9pOz CRGWza5RY0ug7OPm/WUK+X7nlLTFgGjSa8luEqTmdN1KL3S4zCdAu8QwZiAQVMiX5mGP PVcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=oyadEz0eZwOz4veMiu/99Xwk84Lj2bAOI1P6STGAbTM=; b=EsH5CFGqWVvBoO2EQvcafl/WzqmLGVORyzx5HSdlfuqDMC5HYCcHkL+cQ8qPhztm/v w8Mt6ZQnRlfa7DR1N3T+R8BWtdzDuVRnGijGGetQxWuK8S9xzJAO98UQ9m78BNZFFH5B ryWqh/YGCQpnmIfqSwC0cKYMrReA5Wo6oAeuf3g746m5mOuK3TOyguEkktAuXboZgq4P BS/EAwvJDI3J8jDSvZ8wXlWlxxitc14XkGqkSdILyzBV9u9eFXqoHo/EpsR7AMSXvmsR lcmfmTi9cyLrDtNZTyp24Y34MFpXIcq0pVRXQR1XNJDLXyxHTDh2OKM5lhDw7OWd8Dhz 8exA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pzO5UY59; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci27si11374905ejc.179.2020.07.20.04.59.42; Mon, 20 Jul 2020 05:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pzO5UY59; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbgGTL6f (ORCPT + 99 others); Mon, 20 Jul 2020 07:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728058AbgGTL6e (ORCPT ); Mon, 20 Jul 2020 07:58:34 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 993AEC061794; Mon, 20 Jul 2020 04:58:34 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id u64so1671314qka.12; Mon, 20 Jul 2020 04:58:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oyadEz0eZwOz4veMiu/99Xwk84Lj2bAOI1P6STGAbTM=; b=pzO5UY59E2I78nkbHVVchIb8xSq5dpsUcOpNS7Gkxof5sNSjCEODEhGzsvVVjAfJyl VSwzSp6U1Zs9krrRKUF/u2Bk2AkyMb7A4vyZNN5lBySozBpWv75kuuSymSQ75I0lOQIq /aNfumnu9UNKeQqzNIgsFnNCRnWlLEXCl5HKsdcBqoLY2AX4WupdTDUkutMtkReFDd/p 7rLcMb8CsQvVO2aMkGCvC0cISIr9opF8PILSUSavYLWpTTSmyGJ8atrT4DsGICF1czPS GjukeM8re+7Is53uuqLc1gz9fVVpsyasqxmhyXdVNJb4jwNSaNcNEMbvPaz5r/mI8alC KLmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oyadEz0eZwOz4veMiu/99Xwk84Lj2bAOI1P6STGAbTM=; b=Y4CledokJc6GI0n6XJUpXO1Iy42iDV40Vm+i5Wi3eBacq6KYNoq2KmB/n0j0qQjhPG WdxK8emySDybueGcv3LByUrKFevz9aAbJ/3IxzNipfzWfhxsTq/T+SksofUineYlu54L Pslw2GWv1VqlEgN8FK37XazhuIGKVOy3u8npCkdODWcOyRdUKdXTnbwOYSUi/XirioQc CzZe6vlB7aGJ4VWVbqEx9odqL4KpN3xZuv/zoqIftUimPxwH5jVOE+UwVbL1WH5Ww6ls zQ9ZAj3mgWe6KuuupeV7V71IxbsiZCbsC/+GL4NsejI1C0mo7PbieQGG3ElJeq22e8h1 Psgw== X-Gm-Message-State: AOAM532q4BcFDn1SQcD5gmDldO30sN4yaHsco2aHqOARwywJsH+20skt 49xWIm1A2aRCQiYZixu2lANPEEGq6GbwUMqIGsw= X-Received: by 2002:a37:9147:: with SMTP id t68mr20753351qkd.34.1595246313907; Mon, 20 Jul 2020 04:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-5-hch@lst.de> In-Reply-To: <20200720075148.172156-5-hch@lst.de> From: Richard Weinberger Date: Mon, 20 Jul 2020 13:58:22 +0200 Message-ID: Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init To: Christoph Hellwig Cc: Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , linux-mtd@lists.infradead.org, device-mapper development , linux-block@vger.kernel.org, LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , linux-mm@kvack.org, cgroups mailinglist Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Chrstoph, On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > Set up a readahead size by default. This changes behavior for mtd, > ubifs, and vboxsf to actually enabled readahead, the lack of which > very much looks like an oversight. UBIFS doesn't enable readahead on purpose, please see: http://www.linux-mtd.infradead.org/doc/ubifs.html#L_readahead -- Thanks, //richard