Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 20 Jul 2020 15:00:39 +0300
From:   Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To:     Sam Ravnborg <sam@ravnborg.org>
Cc:     Philipp Zabel <p.zabel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Lucas Stach <l.stach@pengutronix.de>, agx@sigxcpu.org,
        lukas@mntmn.com, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/4] drm/imx: Add initial support for DCSS on iMX8MQ
Message-ID: <20200720120039.7jnh2vysebjh7oxh@fsr-ub1864-141>
References: <20200717144132.2206-1-laurentiu.palcu@oss.nxp.com>
 <20200717144132.2206-3-laurentiu.palcu@oss.nxp.com>
 <20200717194849.GA2369507@ravnborg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200717194849.GA2369507@ravnborg.org>
User-Agent: NeoMutt/20171215
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fsr-ub1864-141 (83.217.231.2) by AM4PR0701CA0013.eurprd07.prod.outlook.com (2603:10a6:200:42::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.17 via Frontend Transport; Mon, 20 Jul 2020 12:00:41 +0000
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 69841666-1097-429c-e5db-08d82ca48706
X-MS-TrafficTypeDiagnostic: VI1PR04MB3997:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR04MB39978CD37019054D5FDE5F00BE7B0@VI1PR04MB3997.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ophhV9zPJ0h4F4PiiJikZZo/ZRfREurbJYtcVXI/Pkzeg+A9mNVwVkx1kJ1R3esC3xzgXfWMX/r4AgF29jT2dVXwMWpUMvQ5WFLPDcogXgyqjKJcMkdTQfJZu1d8P3DBjKhlPVTX1YcZMLus5TYmXDbED7lbpQ7BOIjYiFcSsmhQbSRsoSLp4uS60mUTtdDjj8yDx4JBS+VWsDj9wWXrAfJqcMfL8TWIQk5jZbq8tStpd0Ngy5UIyEuvHIkZHuGjH4Jv25P+XFHBbhh6lPM0MekOix9ibqIxlki/X+VCgaaLRxVIRHrZdxGdNyry8nCPpd8ruybkDz3oi4dawml0ZV2dd/Q58FkgFVsaVmZvp+ATHaJfl9TUDrwQQ7gOv2vbKpM3FleZFxQ23CbT1CkJ3bPHvopC9M3u2FV6waC2W/Br0oISDLmuBgLInueWipcPYHuy5LFAgE5vwJ4oCVN8Fg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3902.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(8676002)(66946007)(66476007)(66556008)(2906002)(316002)(8936002)(33716001)(55016002)(6916009)(9686003)(1076003)(7416002)(86362001)(83380400001)(5660300002)(52116002)(26005)(186003)(16526019)(6496006)(956004)(4326008)(966005)(478600001)(44832011)(54906003)(32563001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: HTwJLr7crK2XVsG2xl6gwC/IWHkHVJgvBlQAqOmAUgQtCqTLGd94tNXEUseJK8aJZU5fNSqDM2ac+E3pvuCTEYoF3ac40Esx/Y2Y7oobmgJtmczZmTFLKRCh5DRInmTOfs6hMZhjx+KgF70n/r06lSQYjl3hie3geGY1nPdJ83yNtAAT3Xj3WhXFOKv0BS4jXra0kyOw3DgtaZaywWVSyt4Se5zuHUhzOwOGRpLxAyNxCjCvnRkug0ceVlhBXJlzfICFTCZDorQkONEfDeqTYOo3c607CwgpicohdA5Mzm9yup6RvwZQL7glWrRcDh9vShKHdIBoPYqiVZKZ5Pc4DRiwCL29VxAXh2XXbdCKPRxTcT0u74/csynAjFgbN8R907BPNJa5RzQ1tNet947StvIlFpBEipTLqrWuSUCCXgsxfsvx56J4Mi5xDm5ZnQDNYomBRhBYaPqktuSU/eIc0fXlWVPArfpcEM0jzge4GVI=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69841666-1097-429c-e5db-08d82ca48706
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3902.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2020 12:00:42.9427
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lrWmHyFPckKA5TI7rDRh/gbAmFrNjIDOTXcXeqBayt4RFi+Emjb2hgGouz/PRShbd1r42CvuSXi9A+WFFkCsFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3997
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sam,

On Fri, Jul 17, 2020 at 09:48:49PM +0200, Sam Ravnborg wrote:
> Hi Laurentiu.
> 
> On Fri, Jul 17, 2020 at 05:41:27PM +0300, Laurentiu Palcu wrote:
> > From: Laurentiu Palcu <laurentiu.palcu@nxp.com>
> > 
> > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS).
> > Some of its capabilities include:
> >  * 4K@60fps;
> >  * HDR10;
> >  * one graphics and 2 video pipelines;
> >  * on-the-fly decompression of compressed video and graphics;
> > 
> > The reference manual can be found here:
> > https://www.nxp.com/webapp/Download?colCode=IMX8MDQLQRM
> > 
> > The current patch adds only basic functionality: one primary plane for
> > graphics, linear, tiled and super-tiled buffers support (no graphics
> > decompression yet), no HDR10 and no video planes.
> > 
> > Video planes support and HDR10 will be added in subsequent patches once
> > per-plane de-gamma/CSC/gamma support is in.
> > 
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> 
> ....
>         return drm_bridge_attach(encoder, bridge, NULL, 0);
> ....
> 
> The above code-snippet tells that the display-driver rely on the bridge
> to create the connector.
> Could this by any chance be updated to the new way where the display
> driver creates the connector - and thus passing DRM_BRIDGE_ATTACH_NO_CONNECTOR
> as the flags argument?

OK, I can give this a shot and the changes will be part of a separate patch
within this patchset, if that's ok with you. No need to go through
and review the entire driver again for this...

Thanks,
laurentiu

> 
> What bridges would be relevant?
> To check that the reelvant bridges are already ported.
> 
> 	Sam