Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1696803ybh; Mon, 20 Jul 2020 05:08:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxVe8qhcEawswT90/MbASX3XsJ1yMrJUGhpwQ91D1qTIp/nEVPxkuIwtyxPUZHkAtB2szp X-Received: by 2002:a50:fe16:: with SMTP id f22mr21282818edt.315.1595246925320; Mon, 20 Jul 2020 05:08:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595246925; cv=none; d=google.com; s=arc-20160816; b=ZKrovmvMvfPoePAuXIT8MAKEDZeCdFf7Uc5yhqdyodox6uGx0WiQyHpYbizNSKJAkI jO9XeA4qtKiOWRkd0wIGuesHyTjbuz8wgJ1CBfBcFW2TouebdMs8rUv0OC6K4TYxdyzM RaoINbbB4ZGjeSoE5m0EOUYVR1QtAG3Nwtt5eTOrj6jcNbPRc12ajm6s2ptzP7DzSX1s tCyHBQSD2m8JUD3QjdDRjzG+6kNQL6myaeA2heDc4wyix9Go37bovvLchResWvr72vcX LJsusiEnkyro8hHHp1tfHZmvNAYq1JHJlYwHaTDOt2rwRYlj3No4TsfHskUGdC9OBYpj q22A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=XiTdb9HAq3/H4TfPctaFKZSM9pg/js4njTCittHfEnY=; b=YznrK57IuJXNns2HRAyeyuj+e28EnvKJnQsWWEcUujWDwwAhrRQy+Kv+bvttwvFWaB rvqMU2YeJ5FYA4A55MnC4rotD5Ez/gJHO69tI6MbWzbpG/LB3TRy7Y/2shiEqEaVoakC 7guQdFf0UNfvPgVeQ4uc6c3ouAe5fjQUYHZLiCHN0wTlRKLDbBr3jZVvmdnZF/neYDCy UxmrZOjmf8IJ0s3I829gBEcG4mlzMHQoW3jdkAsGCNK4n6earRZSZPyv1g1pJ0WiQV+0 rsUQ7lR2qLkB1KkGIsUEiyD9JkB0+qIOULMf0RZW/HbIj/rFCAJMrqL5acsa7Pj6mKrO mymg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p7si10312371edm.514.2020.07.20.05.08.21; Mon, 20 Jul 2020 05:08:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbgGTMHk (ORCPT + 99 others); Mon, 20 Jul 2020 08:07:40 -0400 Received: from verein.lst.de ([213.95.11.211]:46623 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728712AbgGTMHi (ORCPT ); Mon, 20 Jul 2020 08:07:38 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 18CA168BFE; Mon, 20 Jul 2020 14:07:35 +0200 (CEST) Date: Mon, 20 Jul 2020 14:07:34 +0200 From: Christoph Hellwig To: Richard Weinberger Cc: Christoph Hellwig , Jens Axboe , Song Liu , Hans de Goede , Richard Weinberger , linux-mtd@lists.infradead.org, device-mapper development , linux-block@vger.kernel.org, LKML , drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel , linux-mm@kvack.org, cgroups mailinglist Subject: Re: [PATCH 04/14] bdi: initialize ->ra_pages in bdi_init Message-ID: <20200720120734.GA29061@lst.de> References: <20200720075148.172156-1-hch@lst.de> <20200720075148.172156-5-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 20, 2020 at 01:58:22PM +0200, Richard Weinberger wrote: > Hello Chrstoph, > > On Mon, Jul 20, 2020 at 9:53 AM Christoph Hellwig wrote: > > > > Set up a readahead size by default. This changes behavior for mtd, > > ubifs, and vboxsf to actually enabled readahead, the lack of which > > very much looks like an oversight. > > UBIFS doesn't enable readahead on purpose, please see: > http://www.linux-mtd.infradead.org/doc/ubifs.html#L_readahead What about jffs2 and blk2mtd raw block devices?