Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1719225ybh; Mon, 20 Jul 2020 05:39:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywOdaxUpvAsEtmWsq6fCchh/f5i+mNq7ErdT+a1vlkUfdEPP2JCs8dqns8vqKB4/sTCLBo X-Received: by 2002:a17:906:dbe5:: with SMTP id yd5mr20773199ejb.328.1595248797503; Mon, 20 Jul 2020 05:39:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595248797; cv=none; d=google.com; s=arc-20160816; b=j6wy5Yj+RgrWNXr+92qW6JGDEC4y2GMA+RIr7kS7FkAJ/fpvwWRtsE9JbeBBt3aFVf xMulNhN26RpbBz4CkabghVDNskfoVYQeirKf3m8L8+RY9ivm7tEpWQNdbKIP7+WIBv6F rVuMH4yirQc04ZCqYF4GPsoz5LeVclSAsrlpbZ3uUvyJ3beeCfFyJ42eKHLHXnJ6zdJA 5xrIoLeXtHVRK2dyyeDiSu5t1bCPgsXp06Ysz4mQXFE8XOeIdcwGWGrS825J9dNqRv7p puUxcl57m1bgXp5aRtr6iKIfGVrZou235A7y7IBqbGrbmwV5qWomGPcgOMb23UEoD+i4 WW+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=nlH1txpzzHq6B7hbqH5b0L3jlFHePu8PYnWK2kXfyys=; b=tAzPFNTNkPTOb8ImgNGLAHW7FsVeVZyencbFYR6bAI8VoqRtlcu5QVSH4U9oXIi8rG BkXWGEcwm2SLAFK52Q8l7N2DyG2O4J7tUsS+vEOlMYycF39QZ1D55WlAsxRTSyQTAx6l Ux/o5P1vrVU2Q8kPlra6zQffeuSbAGktgw0FbAwETZ8HjQbEDRZU5bI2Dp0B0//d/6r3 MwxbAKDzVK5X5Qdbr1qMs5o1He7P4r3ymKE5ZzLQl8OU5uAuz5/W73e7TUsLbEIpCR+W OhzK0W7jvpel8IxkJSVqR4BUTV+xnqzciQsUh7aH1+w7BIjFi9QJ9ADBisP4o6BRGkCB O6pg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f23si10225571edw.582.2020.07.20.05.39.35; Mon, 20 Jul 2020 05:39:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728707AbgGTMiW (ORCPT + 99 others); Mon, 20 Jul 2020 08:38:22 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7798 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728200AbgGTMiV (ORCPT ); Mon, 20 Jul 2020 08:38:21 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 47BB1A1FCCCF437FFB8A; Mon, 20 Jul 2020 20:38:19 +0800 (CST) Received: from [10.164.122.247] (10.164.122.247) by smtp.huawei.com (10.3.19.212) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 20 Jul 2020 20:38:14 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages To: Markus Elfring , CC: , Jaegeuk Kim References: <6074306e-e909-e17f-900c-320245a8f869@web.de> From: Chao Yu Message-ID: <8be91065-7c85-9501-f1c2-3cf11aab85a5@huawei.com> Date: Mon, 20 Jul 2020 20:38:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6074306e-e909-e17f-900c-320245a8f869@web.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.164.122.247] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/7/20 19:31, Markus Elfring wrote: >> Memory allocated for storing compressed pages' poitner should be >> released after f2fs_write_compressed_pages(), otherwise it will >> cause memory leak issue. > > * Would an imperative wording be more appropriate (without a typo) > for the change description? > > * Will the tag “Fixes” become helpful for the commit message? It looks this is replied from patch-robot? since I found all comments you replied are almost the same. And what's funny is that the reply starts being caught by another patch-bot from Greg... https://lkml.org/lkml/2020/6/28/157 > > Regards, > Markus > . >