Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
To:     Andrzej Hajda <a.hajda@samsung.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
Cc:     linux-imx@nxp.com, laurentiu.palcu@oss.nxp.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/bridge/adv7511: set the bridge type properly
Date:   Mon, 20 Jul 2020 15:42:27 +0300
Message-Id: <20200720124228.12552-1-laurentiu.palcu@oss.nxp.com>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fsr-ub1864-141.ea.freescale.net (83.217.231.2) by AM0PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:208:d2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17 via Frontend Transport; Mon, 20 Jul 2020 12:43:28 +0000
X-Mailer: git-send-email 2.17.1
X-Originating-IP: [83.217.231.2]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 6720e8b6-0ad5-4ee3-256d-08d82caa8108
X-MS-TrafficTypeDiagnostic: VE1PR04MB6493:
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VE1PR04MB6493E8136F60249608F7F926BE7B0@VE1PR04MB6493.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: PwhHG2I+8X/T7ZexsKSlg0k5q4yEFynmo0xl94cE4fjBjoLqXYRctqPNByerqZT/LTxmjWrjRFskuHitl3KeNqa7J5RRZmgO3FotR9P4CBU0Q6WOLjzIQijcu0oWW73PbBC2FDxR6b6M3dtVihR5ombxvFufGMgQ8whjK1tZKdeJAvF3t8rTKFh3WLOC+M1HZkcS9sSqTxK2Pjxwj0+/6O7EBdPuoguA4A/PJwf+cCldgtMnX/hsEWV+wQS5U5KZoelXKy1BikiNtNbg1lsCElfHuf+LZzsrpT6p5dYkMk4enKrDDQUbiq+zJsiUHF661bskn803LtjqW/eGQHv9yg==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3902.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(396003)(39860400002)(376002)(346002)(136003)(110136005)(6512007)(316002)(66476007)(83380400001)(66946007)(66556008)(4326008)(6486002)(186003)(2906002)(52116002)(86362001)(44832011)(8936002)(26005)(1076003)(956004)(5660300002)(478600001)(8676002)(16526019)(6506007)(2616005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: nwSZALFzVmUL7rHq2yhNgMx9LQg67Gspm/lOjKXRzSFUb6Yk5pEaCf/D3vIGQ0Y7o3L9TpOrBV4fHnDUN1z+Pc9MtM/hPOEf/ABWOmXHSe+yUBnWF7FUMTNcuNN8pTD2aNng3Epzac7pROI60Z2CfxuGfnwIgU7Y3bdaRHRSfBZkq8ut0+Yo+rVZzRVSQLsqIXwtueamSvwf5LFeFWjLJ3to1kNenqR4GrxIVVw6F+G9wcbInKdaryGVG6riwdWmSHJvqInxlB3GhK6O2kEYkv+lJI55FqCkki//MaSuSJDIi+SjgZDZYLdow1xaJ58GLsBsGpm6EPAcLZ3qhvtLpOV6rAHY5tYskKnhx7NvnS9HWoKkcwPJK6y3pz82yZtSS86GzHvEzf4q4SI1PWcE0jpXEnQ2P7ZC1hfyneV/PTZilUvzPcpM6r1cp2bhu5Ctby+38DHoYyW/AjVkz8cc1RUi7GTagS7U9HDVcvdkfzs=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6720e8b6-0ad5-4ee3-256d-08d82caa8108
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3902.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2020 12:43:29.7920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZA6w9gIvjEh252iuFMVVPjAn7rt6BC6mduprI0djzjQg7acphV+CMAylSDwhXasQPIbv9X92D+yAdbu6eWKc7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6493
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Laurentiu Palcu <laurentiu.palcu@nxp.com>

After the drm_bridge_connector_init() helper function has been added, the ADV
driver has been changed accordingly. However, the 'type' field of the bridge
structure was left unset, which makes the helper function always return -EINVAL.

Signed-off-by: Laurentiu Palcu <laurentiu.palcu@nxp.com>
---
Hi,

I've hit this while trying to use this helper in the new i.MX8MQ DCSS
driver, as suggested by Sam, and I wanted to test it with NWL MIPI_DSI and
ADV since support is already in mainline.

Thanks,
laurentiu


 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f45cdca9cce5..a0d392c338da 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
 	adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
 			    | DRM_BRIDGE_OP_HPD;
 	adv7511->bridge.of_node = dev->of_node;
+	adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
 
 	drm_bridge_add(&adv7511->bridge);
 
-- 
2.23.0