Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200713134114.137265-1-gnurou@gmail.com> <20200714223344.GA20740@amd>
 <CAAVeFuKomLcAue9rGXhK3Uc=H+v9ZLBA84Ozr_rZDRQMYeC=dg@mail.gmail.com>
 <17fe52a2-73ff-b547-8a59-5df009c929c8@gmail.com> <CAAVeFuJQCp7Fpqx3nUHMy29Jw1pLNoQtxRw3qxfEf3YKnrm0fw@mail.gmail.com>
 <20200717074410.GA8895@amd> <756fa49f-bf67-0447-cf45-1358b66c40f8@gmail.com>
In-Reply-To: <756fa49f-bf67-0447-cf45-1358b66c40f8@gmail.com>
From:   Alexandre Courbot <gnurou@gmail.com>
Date:   Mon, 20 Jul 2020 22:07:03 +0900
Message-ID: <CAAVeFuLxKO9nJ+1GDuAr+-Z_BQMZpEVD46F2j=dZ3hDUv-eE=A@mail.gmail.com>
Subject: Re: [PATCH] leds: add NCT6795D driver
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc:     Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-leds@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jul 18, 2020 at 4:25 AM Jacek Anaszewski
<jacek.anaszewski@gmail.com> wrote:
> >
> >> The reason for not having a function at the moment is that I took a
> >> look at include/dt-bindings/leds/common.h and could not find any
> >> function that could reasonably apply. This basically controls a RGB
> >> connector on the motherboard which serves no particular function - you
> >> can plug a RGB fan or anything else you want and control it in any
> >> fashion. Is there a function that applies to this use-case?
>
> According to common LED bindings you should propose a new function
> if none of the existing ones fits your needs.
>
> > This is normally used for motherboard lightning, right? I believe this
> > is getting common on gaming boards, and we want common support for
> > that.
>
> I agree.

These boards are indeed far from being a rarity so having a function
for them (maybe named LED_FUNCTION_RGB_HEADER?) makes sense IMHO. I'll
submit a patch for that with the next revision.

Speaking of which, after looking at the multicolor patchset it is
pretty obvious that it would be a much better way to expose this RGB
header, so I think I will wait until it is merged and adapt the driver
to use it.

Thanks for the feedback!
Alex.